book: Add logo and support text to introduction
#527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Urhengulas
requested review from
japaric and
Mirabellensaft
and removed request for
japaric
|
LGTM, but for further iteration we should have the request for sponsoring visually separated from the content. Something like a banner or so. |
Mirabellensaft
approved these changes
Jul 7, 2021
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 7, 2021
527: `book`: Add logo and support text to introduction r=Urhengulas a=Urhengulas Fixes #420. ## preview (https://deploy-preview-527--eager-mestorf-d2af88.netlify.app/)  Co-authored-by: Johann Hemmann <johann.hemmann@code.berlin>
|
bors cancel |
|
Canceled. |
|
@Mirabellensaft What do you think about the added sponsor card (stolen from the knurling website)? Not quite a banner, but definitely more apparent. |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #420.
preview
(https://deploy-preview-527--eager-mestorf-d2af88.netlify.app/)
