Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode and format f32 #70

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Encode and format f32 #70

merged 1 commit into from
Aug 5, 2020

Conversation

Lotterleben
Copy link
Contributor

(partially?) resolves #53 – no support for f64 for now

jonas-schievink
jonas-schievink reviewed Aug 5, 2020
View reviewed changes
src/impls.rs Outdated Show resolved Hide resolved
@jonas-schievink
Copy link
Contributor

f32 should also be added to as_native_type in src/macros/lib.rs

@Lotterleben
Copy link
Contributor Author

done

@jonas-schievink
Copy link
Contributor

Forgot to push?

@Lotterleben
Copy link
Contributor Author

almost– typo in "git commit" 😬

@jonas-schievink jonas-schievink merged commit 2abaef2 into main Aug 5, 2020
@jonas-schievink jonas-schievink deleted the encode_fmt_floats branch August 5, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-schievink jonas-schievink jonas-schievink approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

encode and format floats
2 participants
@Lotterleben @jonas-schievink