Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defmt-parser: Simplify tests with rstest #743

Merged
merged 6 commits into from
Mar 21, 2023
Merged

defmt-parser: Simplify tests with rstest #743

merged 6 commits into from
Mar 21, 2023

Conversation

Urhengulas
Copy link
Member

This PR uses the rstest crate to drastically reduce the amount of testing code while keeping the same tests. Additionally, there is now more granular error reporting.

parser/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@BriocheBerlin BriocheBerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@BriocheBerlin
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 21, 2023

Build succeeded:

  • ci

@bors bors bot merged commit 30e88ff into main Mar 21, 2023
@bors bors bot deleted the parser-tests branch March 21, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants