Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate ip_in_core feature #805

Merged
merged 6 commits into from
May 13, 2024
Merged

Deprecate ip_in_core feature #805

merged 6 commits into from
May 13, 2024

Conversation

Urhengulas
Copy link
Member

This PR removed the ip_in_core feature from defmt and re-enables nightly shapshot tests. See #803 for details.

@Urhengulas Urhengulas added the status: blocked Blocked on another issue, or on upstream libraries label Jan 16, 2024
@Urhengulas Urhengulas force-pushed the remove-ip_in_core-feature branch from 6bd21ce to 0deae8c Compare January 29, 2024 15:50
@newAM
Copy link
Member

newAM commented Mar 21, 2024

Rust 1.77 is out! https://blog.rust-lang.org/2024/03/21/Rust-1.77.0.html

Would it be possible to get a release after this is merged?

@newAM newAM mentioned this pull request Mar 22, 2024
Merged
@Urhengulas
Copy link
Member Author

Rust 1.77 is out! https://blog.rust-lang.org/2024/03/21/Rust-1.77.0.html

Would it be possible to get a release after this is merged?

Sure

@Urhengulas Urhengulas force-pushed the remove-ip_in_core-feature branch from 0deae8c to 40dece7 Compare March 25, 2024 13:20
@Urhengulas Urhengulas marked this pull request as ready for review March 25, 2024 13:21
@Urhengulas
Copy link
Member Author

Removing a cargo feature is a breaking change, right?

@Urhengulas Urhengulas added the breaking change fix / feature / improvement involves a breaking change and needs to wait until next minor version label Mar 25, 2024
@newAM
Copy link
Member

newAM commented Mar 25, 2024

Removing a cargo feature is a breaking change, right?

Yes, but the feature can be left in (without doing anything) to avoid this.

@Urhengulas Urhengulas force-pushed the remove-ip_in_core-feature branch from 26702c6 to d736c62 Compare March 25, 2024 14:59
@Urhengulas Urhengulas force-pushed the remove-ip_in_core-feature branch from 488265e to 25f66ea Compare May 13, 2024 14:23
@Urhengulas Urhengulas changed the title Remove ip_in_core feature Deprecate ip_in_core feature May 13, 2024
@Urhengulas Urhengulas force-pushed the remove-ip_in_core-feature branch from 25f66ea to ff7258b Compare May 13, 2024 14:33
@Urhengulas Urhengulas removed status: blocked Blocked on another issue, or on upstream libraries breaking change fix / feature / improvement involves a breaking change and needs to wait until next minor version labels May 13, 2024
@Urhengulas Urhengulas force-pushed the remove-ip_in_core-feature branch from 401f698 to 16d5eac Compare May 13, 2024 15:43
@Urhengulas Urhengulas merged commit 601a1a8 into main May 13, 2024
15 checks passed
@Urhengulas Urhengulas deleted the remove-ip_in_core-feature branch May 13, 2024 15:45
@Urhengulas
Copy link
Member Author

@newAM defmt 0.3.7 was released just now

@astapleton astapleton mentioned this pull request May 13, 2024
Closed
Urhengulas added a commit that referenced this pull request May 16, 2024
@Urhengulas
Revert "Merge pull request #805 from knurling-rs/remove-ip_in_core-fe…
1ff6a52 
…ature"

This reverts commit 601a1a8, reversing
changes made to 97f6e80.
Urhengulas added a commit that referenced this pull request May 16, 2024
@Urhengulas
Revert "Merge pull request #805 from knurling-rs/remove-ip_in_core-fe…
c4ae28b 
…ature"

This reverts commit 601a1a8, reversing
changes made to 97f6e80.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Urhengulas @newAM