Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on Rust 1.83 #902

Merged
merged 3 commits into from
Nov 29, 2024
Merged

Fix build on Rust 1.83 #902

merged 3 commits into from
Nov 29, 2024

Conversation

jonathanpallant
Copy link
Contributor

Rust 1.83 came out yesterday and adds some new warnings. As we build in CI with -D warnings, this broke our CI builds.

They should now work again.

Avoids "error: the following explicit lifetimes could be elided: 'a"
Copy link

cloudflare-workers-and-pages bot commented Nov 29, 2024

Deploying knurling-defmt-book with  Cloudflare Pages  Cloudflare Pages

Latest commit: 12c3874
Status: ✅  Deploy successful!
Preview URL: https://ad9bb55c.knurling-defmt-book.pages.dev
Branch Preview URL: https://fix-rust-183.knurling-defmt-book.pages.dev

View logs

firmware/defmt-rtt/src/lib.rs Show resolved Hide resolved
@jonathanpallant jonathanpallant added this pull request to the merge queue Nov 29, 2024
Merged via the queue into main with commit 8924d3b Nov 29, 2024
26 checks passed
@jonathanpallant jonathanpallant deleted the fix-rust-183 branch November 29, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants