Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify #28

Merged
merged 9 commits into from
Mar 29, 2021
Merged

Simplify #28

merged 9 commits into from
Mar 29, 2021

Conversation

Urhengulas
Copy link
Member

This PR contains various simplifications and improvements of code and docs :)

@Urhengulas Urhengulas requested a review from japaric March 28, 2021 23:02
@Urhengulas Urhengulas self-assigned this Mar 28, 2021
jonas-schievink
jonas-schievink approved these changes Mar 29, 2021
View reviewed changes
Copy link
Contributor

@jonas-schievink jonas-schievink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Found a slightly unclear comment, other than that this looks good.

src/main.rs Outdated Show resolved Hide resolved
@Urhengulas
Update src/main.rs
d9bdad5 
Co-authored-by: Jonas Schievink <jonas.schievink@ferrous-systems.com>
@Urhengulas
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 29, 2021

Build succeeded:

@bors bors bot merged commit 3e43bab into main Mar 29, 2021
@bors bors bot deleted the simplify branch March 29, 2021 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonas-schievink jonas-schievink jonas-schievink approved these changes

@japaric japaric Awaiting requested review from japaric

Assignees

@Urhengulas Urhengulas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Urhengulas @jonas-schievink