Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search linker scripts in cwd first #63

Merged
merged 2 commits into from
Jan 10, 2022
Merged

search linker scripts in cwd first #63

merged 2 commits into from
Jan 10, 2022

Conversation

spookyvision
Copy link

harmonize linker script directory search order with non-flip-link linkers to reduce surprises.
Specifically, other crates might introduce spurious and potentially wrong memory.x scripts, this PR attempts to do some damage control by searching the current working directory first

Copy link
Member

@japaric japaric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! but clippy is unhappy on some existing code. could you please do a drive-by fix? (I think I've seen that warning before and it was a false positive iirc; if that's the case silencing it with #[allow] is fine)

@japaric
Copy link
Member

japaric commented Jan 10, 2022

bors r+

@bors bors bot merged commit d55e7c8 into main Jan 10, 2022
@bors bors bot deleted the linker-dirs-order branch January 10, 2022 17:54
@bors
Copy link
Contributor

bors bot commented Jan 10, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants