End of year refactoring #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dajamante
reviewed
Dec 5, 2022
Dajamante
reviewed
Dec 5, 2022
Dajamante
reviewed
Dec 5, 2022
Dajamante
reviewed
Dec 5, 2022
| @@ -147,7 +137,7 @@ fn compute_span_of_ram_sections(ram_entry: MemoryEntry, object: object::File) -> | |||
| let mut found_a_section = false; | |||
| for section in object.sections() { | |||
| if let SectionFlags::Elf { sh_flags } = section.flags() { | |||
| if sh_flags & elf::SHF_ALLOC as u64 != 0 { | |||
| if (sh_flags & elf::SHF_ALLOC as u64) != 0 { | |||
There was a problem hiding this comment.
Is it bit comparison here?
There was a problem hiding this comment.
It is. I was confused by that as well in the beginning, therefore I added the brackets.
There was a problem hiding this comment.
Yes this is nitty-gritty 🗡️ ! Should we add a comment to say what flags this check looks at?
There was a problem hiding this comment.
We should, but I don't know. SHF_ALLOC says that "Section occupies memory during execution.".
There was a problem hiding this comment.
I'd prefer not to block this PR on this, but figure out what the check does and add a comment in a separate PR.
Dajamante
reviewed
Dec 5, 2022
|
bors r=Dajamante |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the refactorings were triggered by clippy, others by just getting into the refactor mood.