Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #317
This change effectively forks the parts of genericclioptions that we use (i.e., global kubectl flag definitions) into an
internal
package, where flags are documented as deprecated. It severs our dependency on cli-runtime, and promotes an indirect dep on client-go to a direct one, for now. In a future change, we can remove this package too.If flags are passed before and after
--
, the one after the--
is used:Flags after
--
aren't parsed at all byko
, and are just passed directly tokubectl
: