[WIP] Feature: Add support for verifying base image policies. #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmoor
commented
Jan 1, 2023
mattmoor
commented
Jan 1, 2023
mattmoor
force-pushed
the
verify-base-images
branch
2 times, most recently
from
16abaeb
to
fa3dd46
Compare
Codecov Report
@@ Coverage Diff @@
## main #918 +/- ##
==========================================
- Coverage 51.30% 50.16% -1.14%
==========================================
Files 44 48 +4
Lines 3417 3654 +237
==========================================
+ Hits 1753 1833 +80
- Misses 1435 1588 +153
- Partials 229 233 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mattmoor
force-pushed
the
verify-base-images
branch
from
fa3dd46
to
6d3bd33
Compare
mattmoor
changed the title
mattmoor
force-pushed
the
verify-base-images
branch
from
6d3bd33
to
5648907
Compare
mattmoor
force-pushed
the
verify-base-images
branch
from
5648907
to
c91ac4d
Compare
|
The upstream work is ongoing here: sigstore/policy-controller#480 |
mattmoor
force-pushed
the
verify-base-images
branch
from
c91ac4d
to
565e1f4
Compare
🎁 This implements the very basics from my recent comment on ko-build#356. This still needs the upstream changes to land in a release, but illustrates how the integration will work. /kind feature
mattmoor
force-pushed
the
verify-base-images
branch
from
565e1f4
to
7f28ac9
Compare
mattmoor
changed the title
3 tasks
|
This Pull Request is stale because it has been open for 90 days with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎁 This implements the very basics from my recent comment on #356.
This still needs a bunch of work, but some playing with it and
go runseem to demonstrate what I'd hope for.Things I'd like to do still:
match:,includeSpec:),pkg/policyupstream tosigstore/policy-controllerto facilitate using this in other projects with similar ease (e.g. kaniko, buildpacks, ...)/kind feature
Fixes: #356 (comment)