Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix options #45

Closed
wants to merge 2 commits into from
Closed

fix options #45

wants to merge 2 commits into from

Conversation

stephenmathieson
Copy link
Contributor

closes #44

@stephenmathieson
fix options and misc cleanup
eb6a6b4 
closes #44
@stephenmathieson
Merge branch 'master' into fix/options
a379b94 
* master:
  Added some jsdocs (#43)
  Add missing import (#42)
@stephenmathieson stephenmathieson mentioned this pull request Nov 4, 2017
Closed
@codecov
Copy link

codecov bot commented Nov 4, 2017 •
edited
Loading

Codecov Report

Merging #45 into master will decrease coverage by 9.5%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   78.94%   69.44%   -9.51%     
==========================================
  Files           1        1              
  Lines          38       36       -2     
  Branches       18       11       -7     
==========================================
- Hits           30       25       -5     
- Misses          8       11       +3
Impacted Files Coverage Δ
src/index.js 69.44% <66.66%> (-9.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e8f092...a379b94. Read the comment docs.

@niftylettuce niftylettuce deleted the fix/options branch January 13, 2019 11:26
@niftylettuce
Copy link
Contributor

@coderhaoxin @stephenmathieson fixed and published in v3.0.7 btw

@stephenmathieson
Copy link
Contributor Author

I stopped using this package years ago. Why did it take so long for this to land?

@niftylettuce
Copy link
Contributor

niftylettuce commented Jan 14, 2019 •
edited
Loading

@stephenmathieson for some reason I never got the notification on this thread

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoxins haoxins haoxins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question: omitted options do not set defaults in this.tokens
3 participants
@stephenmathieson @niftylettuce @haoxins