fix: Do not response Content-Length if Transfer-Encoding is defined (#…

…1602)
koajs · Oct 19, 2021 · dbc9c5a · dbc9c5a
1 parent 03643c5
commit dbc9c5a
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/__tests__/response/length.js b/__tests__/response/length.js
@@ -64,3 +64,18 @@ describe('res.length', () => {
     });
   });
 });
+
+describe('res.length=', () => {
+  it('should set when Transfer-Encoding not present', () => {
+    const res = response();
+    res.length = 100;
+    assert.strictEqual(res.length, 100);
+  });
+
+  it('should not set when Transfer-Encoding present', () => {
+    const res = response();
+    res.set('Transfer-Encoding', 'chunked');
+    res.length = 100;
+    assert.strictEqual(res.length, undefined);
+  });
+});
diff --git a/lib/response.js b/lib/response.js
@@ -191,7 +191,9 @@ module.exports = {
    */
 
   set length(n) {
-    this.set('Content-Length', n);
+    if (!this.has('Transfer-Encoding')) {
+      this.set('Content-Length', n);
+    }
   },
 
   /**