Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix styling of Koa vs Express docs #1068

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Fix styling of Koa vs Express docs #1068

merged 2 commits into from
Dec 6, 2022

Conversation

shime
Copy link
Contributor

@shime shime commented Sep 25, 2017 •
edited
Loading

  • split sentences
  • add commas where needed
  • fix various grammar errors
  • replace "node.js" with "Node"
  • replace "koa" with "Koa"

@codecov
Copy link

codecov bot commented Sep 25, 2017 •
edited
Loading

Codecov Report

Merging #1068 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1068   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          487       487           
  Branches       136       136           
=========================================
  Hits           487       487

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39e1a5a...f975b5d. Read the comment docs.

@shime shime force-pushed the docs/fix-koa-vs-express branch 3 times, most recently from bdee003 to 663bed0 Compare September 26, 2017 09:49
@jonathanong
Copy link
Member

sorry, we don't merge style-only PRs. it's not worth the git diff.

can you edit this PR to only fix:

  • grammatical errors (i can't tell what they are from this diff)
  • koa => Koa

@niftylettuce
Copy link
Contributor

Hey @shime nice to see you here 🙌 can you fix the PR per Jonathan's comments?

@shime
Copy link
Contributor Author

shime commented Nov 26, 2017

@niftylettuce 👋 thanks for reminding me, just made the fixes per Jonathan's comments.

fl0w
fl0w reviewed Nov 27, 2017
View reviewed changes
docs/koa-vs-express.md Outdated
@@ -33,10 +33,10 @@ THIS DOCUMENT IS IN PROGRESS. THIS PARAGRAPH SHALL BE REMOVED WHEN THIS DOCUMENT
and less error-prone to write, for the entire stack, not
just the end application code.

Typically many middleware would
Typically many middlewares would
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, only requested change

jonathanong
jonathanong requested changes Jan 31, 2018
View reviewed changes
docs/koa-vs-express.md Outdated
@@ -33,10 +33,10 @@ THIS DOCUMENT IS IN PROGRESS. THIS PARAGRAPH SHALL BE REMOVED WHEN THIS DOCUMENT
and less error-prone to write, for the entire stack, not
just the end application code.

Typically many middleware would
Typically many middlewares would
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, only requested change

3imed-jaberi
3imed-jaberi approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as fix koa => Koa & typo grammar 👍 !

3imed-jaberi
3imed-jaberi reviewed Sep 10, 2020
View reviewed changes
Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shime, can you resolve the conflict then change 'node' >>>> 'Node' !!

3imed-jaberi
3imed-jaberi reviewed Apr 2, 2022
View reviewed changes
Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonathanong, you can approve this PR and merge it 💯 !

3imed-jaberi
3imed-jaberi reviewed Apr 2, 2022
View reviewed changes
Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

3imed-jaberi
3imed-jaberi approved these changes Apr 2, 2022
View reviewed changes
Copy link
Member

@3imed-jaberi 3imed-jaberi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fengmk2 fengmk2 merged commit b3fffc0 into koajs:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fl0w fl0w fl0w left review comments

@jonathanong jonathanong jonathanong requested changes

@3imed-jaberi 3imed-jaberi 3imed-jaberi approved these changes

@fengmk2 fengmk2 fengmk2 approved these changes

Assignees
No one assigned
Labels
version-patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shime @jonathanong @niftylettuce @fl0w @fengmk2 @3imed-jaberi