docs: Fix definition of middleware in guide.md #1810
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to fix the definition of what a middleware is in
guide.md
. The old definition says that middleware are "simple functions which return aMiddlewareFunction
", however every other peice of documentation I could find refers to theMiddlewareFunction
itself as the middleware (not the function that returns theMiddlewareFunction
).If the old definition is intentional and correct, I'm happy to close this PR, but it really seems like it's not correct. E.g. the very next sentence says "When the middleware is run, it must manually invoke
next()
", however if a middleware is the function that returns theMiddlewareFunction
then it wouldn't be able to invokenext()
sincenext
is passed to theMiddlewareFunction
not the function that returns theMiddlewareFunction
.Sorry if this is pedantic, we just had a bit of a back-and-forth on this in a PR and I decided to actually be productive and fix it instead of just complaining to coworkers 😅.
Checklist