Use node test runner #1845
Merged
Use node test runner #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirenkovladd
force-pushed
the
use-node-test-runner
branch
from
89bc549
to
d45e5cd
Compare
sirenkovladd
force-pushed
the
use-node-test-runner
branch
from
243150b
to
cf73bbc
Compare
kevinpeno
reviewed
Oct 20, 2024
| }) | ||
| .on('error', done) | ||
| .end() | ||
| }) | ||
| }) | ||
|
|
||
| it('should catch stream error', done => { | ||
| // TODO |
There was a problem hiding this comment.
What's the TODO regarding?
There was a problem hiding this comment.
thank you, forgot to delete
kevinpeno
reviewed
Oct 20, 2024
kevinpeno
reviewed
Oct 20, 2024
__tests__/application/toJSON.test.js
Outdated
| const assert = require('assert') | ||
| const Koa = require('../..') | ||
|
|
||
| process.env.NODE_ENV = 'test' |
There was a problem hiding this comment.
Why is NODE_ENV now required specifically for this test?
There was a problem hiding this comment.
changed, moved this env to params
kevinpeno
reviewed
Oct 20, 2024
kevinpeno
reviewed
Oct 20, 2024
|
@sirenkovladd, thanks for all the updates! I want to check in with the more seasoned team about the removed test before moving forward. I appreciate your patience! |
kevinpeno
approved these changes
Oct 28, 2024
|
it seems like the tests do not automatically close when I run |
|
hmmm nevermind, it only happened once |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
use
node --testinstead ofjestSee: #1837 (comment)