405 -> 404

[aheckmann]

A request made to a route that has not been defined is returning a 405 instead of 404.

it('missing route should 404', function(done) {
  app.get('/trailing-slash/', function*() {
    this.status = 204
  })

  request(server)
  .get('/trailing-slash')
  .expect(404, done)  // Error: expected 404 "Not Found", got 405 "Method Not Allowed"
});

If the case was that /trailing-slash was defined but not for a GET then a 405 would make sense.

[jonathanong]

hmmm i think this might be routington trailing slash business

[jonathanong]

i'm probably not going to work on this anytime soon since i don't particularly care for this. did you want me to add you as a maintainer for this and routington?

[aheckmann]

sure thing —
Sent from Mailbox

On Tue, Aug 5, 2014 at 12:01 AM, Jonathan Ong notifications@github.com
wrote:

i'm probably not going to work on this anytime soon since i don't particularly care for this. did you want me to add you as a maintainer for this and routington?

Reply to this email directly or view it on GitHub:
#13 (comment)

[nervgh]

@jonathanong

It looks like the issue still exists.

I'm not sure where we need fix that error (trie-router or routington) but
Could we do something simple before parsing url? For example

url = url.replace(/\/$/, '')

[nervgh]

@jonathanong what do you think about it? ⬆️

[jonathanong]

i think it needs to be an option. some people treat trailing slashes differently.

[jonathanong]

yes, i think it's a routington thing

[nervgh]

I'm closing this issue because I've added the note about this behavior into docs. I think one of the possible solutions is to add koa-no-trailing-slash middleware to the top of the middleware queue.