Merge pull request #121 from koalatiapp/fix-fontawesome-cache

fix: ensure fontawesome cache is cleared with new releases
koalatiapp · Mar 24, 2023 · d3e4afd · d3e4afd
2 parents 43adc54 + 50851ec
commit d3e4afd
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/assets/utils/fontawesome-import.js b/assets/utils/fontawesome-import.js
@@ -1,3 +1,3 @@
 import { html } from "lit";
 
-export default html`<link type="text/css" rel="stylesheet" href="/ext/fontawesome/css/all.min.css">`;
+export default html`<link type="text/css" rel="stylesheet" href="/ext/fontawesome/css/all.min.css?v=${window.RELEASE_VERSION || ""}">`;
diff --git a/templates/app_base.html.twig b/templates/app_base.html.twig
@@ -48,6 +48,7 @@
 		{% include "_parts/analytics.html.twig" %}
 
 		<script>
+			window.RELEASE_VERSION = "{{ release_version }}";
 			window.CURRENT_USER_ID = "{{ app.user.id|hashids_encode }}";
 			window.mercureEventSource = new EventSource("{{ mercure(mercure_topic(app.user), mercure_config(app.user))|escape('js') }}", {
 				withCredentials: true

diff --git a/tests/Full/Checklist/comments.spec.ts b/tests/Full/Checklist/comments.spec.ts
@@ -50,7 +50,7 @@ test.describe("checklist", () => {
 		await expect(checklistItem, "Checklist item comment link is updated upon comment creation").toContainText("1 unresolved comment");
 
 		// Reply to the first comment
-		await comment.locator("nb-button >> text=Reply").click({ timeout: 1000 });
+		await comment.locator("nb-button >> text=Reply").click({ timeout: 2000 });
 		const replyEditor = comment.frameLocator("tinymce-editor.ready iframe").locator("[contenteditable]");
 		await replyEditor.click();
 		await replyEditor.type("All good 👍");