Docs rendering #645
Merged
Docs rendering #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
commented
Mar 24, 2024
| @@ -253,6 +253,14 @@ Now let's see what occurs when we add a constraint that enforces the feature to | |||
|
|
|||
| If these features are now passed to a model that supports monotonicity constraints then we can build models with guarantees. | |||
|
|
|||
| ## Outlier Removal | |||
There was a problem hiding this comment.
This can be postponed after we decide for #643
FBruzzesi
commented
Mar 24, 2024
Comment on lines
-106
to
+100
| Notes | ||
| ----- | ||
| See [`sklearn.pipeline.Pipeline`](https://scikit-learn.org/stable/modules/generated/sklearn.pipeline.Pipeline.html#sklearn.pipeline.Pipeline) | ||
| for all other variables. | ||
| for all other parameters other than `log_callback`. |
There was a problem hiding this comment.
This was getting a weird nesting :|
FBruzzesi
commented
Mar 24, 2024
Comment on lines
+23
to
+25
|
|
||
| Example | ||
| ------- |
There was a problem hiding this comment.
Moved the example to top level as in other classes
koaning
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found a few others rendering issues in the docs. Apparently mkdocs material admonitions do not render between keyword sections of mkdocstring (Parameters, Attributes,..).
I am moving those to the top level description.