Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi output support for TrainOnlyTransformerMixin #700

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Multi output support for TrainOnlyTransformerMixin #700

merged 1 commit into from
Sep 9, 2024

Conversation

CarloLepelaars
Copy link
Contributor

@CarloLepelaars CarloLepelaars commented Sep 4, 2024 •
edited
Loading

Description

Solves #699

Adds multi_output=True to check_X_y in TrainOnlyTransformerMixin.fit.

This allows TrainOnlyTransformerMixin to work with multi-output (i.e. 2D) y input.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines (ruff)
  • New and existing unit tests pass locally with my changes
  • All Github Actions pipelines are passing.

FBruzzesi
FBruzzesi approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@FBruzzesi FBruzzesi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CarloLepelaars for reporting the issue and solving it 🙌🏼👌

@FBruzzesi FBruzzesi merged commit 28f2600 into koaning:main Sep 9, 2024
17 checks passed
@FBruzzesi FBruzzesi mentioned this pull request Sep 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FBruzzesi FBruzzesi FBruzzesi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CarloLepelaars @FBruzzesi