fix: Empty swap table with valid swaps #11299
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- add: cloneRawObject - add: override param
- allow `useGrapqh` to be used outside setup , fix [Graphql Subscription] Polling error: Error: vue-query hooks can only be used inside setup() function or functions that support injection context.
- removed: mapToId util - removed: existingCollectionList query
- simple solution to ensure only the latest query result updates the state.
|
@preschian any idea why the preview link is not working?
|
|
|
is not showing the skeleton first better and then fallback to the empty message? |
hhmm, this is new for me. seems like need to check it through netlify dashboard cc @vikiival |
There was a problem hiding this comment.
Anyway, are you able to create a branch directly in kodadot/nft-gallery instead of branching from a fork?
This would allow us to see the deployment preview through Cloudflare Pages, since currently we're not able to see the deployment preview from Netlify. At the moment, Cloudflare Pages doesn't support deployment previews from forked branches
| ...extraVariables, | ||
| }, | ||
| clientId: isRef(client) ? String(client.value) : client, | ||
| const requestId = ++currentRequestId.value |
There was a problem hiding this comment.
We probably don't need the useGraphql composable at all. I prefer using useQuery directly from NuxtApollo instead - that composable alone might be sufficient
There was a problem hiding this comment.
Yep, I like this solution a lot better. new pr #11303
| import { mapToId } from '@/utils/mappers' | ||
| import { unwrapSafe } from '@/utils/uniquery' | ||
|
|
||
| export function useNewCollectionId() { |
There was a problem hiding this comment.
nit: let's move to separate PR regarding remove unused stuff
|
closing in favour of #11303 |
PR Type
Context
Adds the ability to pass
variablesasreftouseGraphqlreviewers kindly also test , tyvm
useNewCollectionIdScreenshot 📸