-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 POW Server side rendering #7725
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request makes extensive changes across multiple files focusing primarily on preventing potential errors during server-side rendering. It introduces checks using External package imports have been modified, such as Some Vue components saw changes to their lifecycle hooks, with moves from the use of 'onBeforeUnmount' hook to 'onMounted' hook for event listeners, specifying essential processes to only run after the component has transitioned into the DOM. Lastly, changes to the project Overall, these changes aim to improve flexibility and compatibility across various environments, potentially enhancing performance, load times, and error handling in both client and server-side contexts. |
Reviewpad Report
|
as long the build and deployed successfull im fine with it 👍🏻 |
So many things to reconfigure on client-side, don't mind first load only showing footer it's normal. |
What can potentially break? |
UI/UX, client side plugin and maybe more? |
And do we need to setup something special from CF/Netlify to work? |
Nope, only check which components needs to be loaded on client-side and which can be loaded on server side. note: SSR is needed for SEO & prerender stuff |
// TODO: persist localstorage (or maybe vueuse equivalent) |
Code Climate has analyzed commit d2a3520 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
more changes in #8356 |
Let me know your thoughts about this change.
SSR is needed if we want to use all Nuxt power