Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test ssr privacy-policy #9014

Closed
wants to merge 4 commits into from
Closed

feat: test ssr privacy-policy #9014

wants to merge 4 commits into from

Conversation

preschian
Copy link
Member

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

  • Closes #<issue_number>
  • Requires deployment <snek/rubick/worker>

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

Copy link

netlify bot commented Jan 15, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit a4609b2
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65a544c639f9450008dfa6da
😎 Deploy Preview https://deploy-preview-9014--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

reviewpad bot commented Jan 15, 2024

AI-Generated Summary: This pull request introduces significant changes across various parts of the codebase. Key shifts are related to client-side operation checks, specifically around localStorage and ensuring certain code blocks are only executed on the client-side. These changes have been brought in to ensure the application's compatibility with both server-side and client-side contexts and prevent potential issues during server-side rendering.

Files such as utils/extension.ts, stores/identity.ts, utils/chain.ts, useLocalStorage.ts, and prefix.global.ts among others have been updated to include these client-side checks, predominantly around operations involving localStorage and hostname checks.

Apart from this, some files have been renamed to include a .client in their names, indicating these scripts are intended for client-side execution. This includes the keyboardEvents.ts, pwa.ts, and polkadot.ts files which have been revised to keyboardEvents.client.ts, pwa.client.ts, and polkadot.client.ts.

The layouts/default.vue file now wraps certain components with a ClientOnly component to restrict their rendering to the client-side.

A new middleware file disable-ssr.ts was also included for disabling Server-Side Rendering for specific paths.

There are also changes in the building and enhancing the memory limit for the build process and version upgrades. The files nuxt.config.ts and package.json received alterations for this purpose, and @polkadot/x-global was updated to version 12.6.2 across the pnpm-lock.yaml file.

Moreover, a new tsconfig.json file was added to the server directory for configuring TypeScript. Overall, these changes are likely aimed at improving the application's robustness, both in terms of client-side and server-side contexts, managing builds, and ensuring the compatibility of scripts.

@reviewpad reviewpad bot added the medium Pull request is medium label Jan 15, 2024
Copy link
Contributor

reviewpad bot commented Jan 15, 2024

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

Copy link

codeclimate bot commented Jan 15, 2024

Code Climate has analyzed commit a4609b2 and detected 5 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 3
Duplication 2

View more on Code Climate.

Copy link

sonarcloud bot commented Jan 15, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@preschian
Copy link
Member Author

met another obstacle :( maybe anyone has another approach @kodadot/internal-dev

@preschian preschian closed this Jan 15, 2024
@preschian preschian deleted the cf-test-ssr-1st-attemp branch January 15, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant