Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: View all - top collections #9959

Merged
merged 5 commits into from
Apr 4, 2024
Merged

feat: View all - top collections #9959

merged 5 commits into from
Apr 4, 2024

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Apr 2, 2024 •
edited
Loading

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

@prury this also touches sorting on both items and explore page, pls also check that sorting works as expected on those pages , thanks

1 - sortby filters working from view all button
2 - can enter an valid url with sort by filters inside the collection page

CleanShot.2024-04-02.at.17.27.20.mp4

Needs QA check

  • @kodadot/qa-guild please review

Needs Design check

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

CleanShot 2024-04-02 at 09 39 14@2x

@hassnian hassnian requested a review from a team as a code owner April 2, 2024 04:40
@hassnian hassnian requested review from vikiival and daiagi and removed request for a team April 2, 2024 04:40
@kodabot
Copy link
Collaborator

kodabot commented Apr 2, 2024

SUCCESS @hassnian PR for issue #9957 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify Netlify
Copy link

netlify bot commented Apr 2, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 799642e
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/660cded23f11c80008ad5838
😎 Deploy Preview https://deploy-preview-9959--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@exezbcz
Copy link
Member

exezbcz commented Apr 2, 2024

helo sir

this weird things happened to the gen art strip, not sure if related
image

and volume sort by is not always applied after clicking
image

@hassnian
Copy link
Contributor Author

hassnian commented Apr 2, 2024 •
edited
Loading

this weird things happened to the gen art strip, not sure if related image

i've seen that happening before, not very often but sometimes when you go from one page to another one,

it's worth creating an issue

and volume sort by is not always applied after clicking image

fixed

@hassnian hassnian marked this pull request as draft April 2, 2024 13:16
@hassnian hassnian marked this pull request as ready for review April 3, 2024 04:45
@codeclimate CodeClimate
Copy link

codeclimate bot commented Apr 3, 2024

Code Climate has analyzed commit 799642e and detected 0 issues on this pull request.

View more on Code Climate.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@exezbcz exezbcz mentioned this pull request Apr 3, 2024
Open
vikiival
vikiival reviewed Apr 3, 2024
View reviewed changes
components/explore/ExploreSort.vue
},
{ immediate: true },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess this is the origin of - kodadot/stick#263 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checking

Copy link
Contributor Author

@hassnian hassnian Apr 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regarding { immediate: true } seems fine , checking further if it's causing any issue

@vikiival I think this might be the problem, it's happening on canary

CleanShot.2024-04-03.at.14.30.35.mp4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do open a new issue :)

@vikiival vikiival mentioned this pull request Apr 3, 2024
Open
@hassnian hassnian mentioned this pull request Apr 3, 2024
Closed
@prury
Copy link
Member

prury commented Apr 3, 2024 •
edited
Loading

not sure how, but i was able to get this result twice when testing PR: (buy now filter appearing on collections)

still trying to understand how to reproduce it

image

how to reproduce:

20240403_161624.mp4

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Apr 3, 2024
@hassnian
Copy link
Contributor Author

hassnian commented Apr 4, 2024

not sure how, but i was able to get this result twice when testing PR: (buy now filter appearing on collections)

still trying to understand how to reproduce it

image

how to reproduce:

20240403_161624.mp4

lul another unrelated bug caused with the search bar, iirc we've seen this happen before in some other PR , where it would add ?listed=true

fixing it

@yangwao
Copy link
Member

yangwao commented Apr 4, 2024

This would be amazing have in release that button I mean

@yangwao yangwao added S-expected-in-upcoming-release-🚚 S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked labels Apr 4, 2024
@yangwao
Copy link
Member

yangwao commented Apr 4, 2024

button works for me and that's kinda really great UX improvement
congrats @hassnian @exezbcz

@yangwao
Copy link
Member

yangwao commented Apr 4, 2024

rest can be fixed for next release or so

@yangwao
Copy link
Member

yangwao commented Apr 4, 2024

Thanks!
pay 50 usd

@yangwao yangwao merged commit bed67b4 into kodadot:main Apr 4, 2024
19 checks passed
@yangwao
Copy link
Member

yangwao commented Apr 4, 2024

😍 Perfect, I’ve sent the payout
💵 $50 @ 8.47 USD/DOT ~ 5.903 $DOT
🧗 16faLfsywwNATaEfbH2ah75dn6ZmctQWpMS5G4KFhbmj5hnD
🔗 0x8345e3d0ddf0938bfae2596b4509eb409de72d50ac1fa0ee4e5b3370bc621e11

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Apr 4, 2024
This was referenced Apr 4, 2024
Merged
Merged
@hassnian hassnian mentioned this pull request Apr 5, 2024
Closed
This was referenced Apr 8, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikiival vikiival vikiival left review comments

@daiagi daiagi Awaiting requested review from daiagi daiagi is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
paid pull-request has been paid S-changes-requested-🤞 PR is almost good to go, just some fine tunning S-expected-in-upcoming-release-🚚 S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explore Collections sortBy filter getting cleared on page mount View all - top collections
6 participants
@hassnian @kodabot @exezbcz @prury @yangwao @vikiival