chore: add generative_uri #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vikiival
reviewed
Jul 1, 2024
| @@ -26,7 +26,7 @@ | |||
| "lint:fix": "eslint --cache --ext .ts,.js,.mjs,.cjs . --fix && prettier -c src test -w", | |||
| "prepack": "pnpm run build", | |||
| "release": "pnpm test && changelogen --release && npm publish && git push --follow-tags", | |||
| "test": "vitest run" | |||
There was a problem hiding this comment.
this will leave vitest in watch mode - not preffered as it cannot run in CI
There was a problem hiding this comment.
vitest able to detect which one development mode or CI
vikiival
requested changes
Jul 1, 2024
hyperdata/src/normalize.ts
Outdated
Comment on lines
81
to
84
| const previewParam = | ||
| meta.previewParam || | ||
| (meta.external_url?.includes('koda') && 'koda') || | ||
| 'fxhash' |
There was a problem hiding this comment.
Preview param of this
ipfs://bafybeihxrnjmqs7po3jw3p37csyscvgxuwg2khow5zm46liutxq466q45m/?hash=0x044852b2a670ade5407e78fb2863c51de9fcb96542a07186fe3aeda6bb8a116
is hash
Suggested change
| const previewParam = | |
| meta.previewParam || | |
| (meta.external_url?.includes('koda') && 'koda') || | |
| 'fxhash' | |
| const previewParam = | |
| meta.previewParam || 'hash' |
There was a problem hiding this comment.
Should this represent collection or NFT
chore(tests): update koda file name in generative tests to match new structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Add
generative_uricompability to hyperdataRef
generative_urito the hyperdata #209PR Type