Merge pull request #685 from ksooo/fix-logspam2

Fix pointless 'Not all properties handled' log spam.
kodi-pvr · Sep 28, 2024 · 39b9b80 · 39b9b80
2 parents dc8d521 + cfb4e0a
commit 39b9b80
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/pvr.hts/addon.xml.in b/pvr.hts/addon.xml.in
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <addon
   id="pvr.hts"
-  version="22.4.1"
+  version="22.4.2"
   name="Tvheadend HTSP Client"
   provider-name="Adam Sutton, Sam Stenvall, Lars Op den Kamp, Kai Sommerfeld">
   <requires>@ADDON_DEPENDS@</requires>

diff --git a/pvr.hts/changelog.txt b/pvr.hts/changelog.txt
@@ -1,3 +1,6 @@
+v22.4.2
+- Fix pointless "Not all properties handled" log spam introduced with v22.4.1
+
 v22.4.1
 - Fix pointless "Unknown property" log spam introduced with v22.4.0
 - Fix update of "DVR configuration" property not working

diff --git a/src/tvheadend/CustomTimerProperties.cpp b/src/tvheadend/CustomTimerProperties.cpp
@@ -34,9 +34,6 @@ std::vector<kodi::addon::PVRSettingKeyValuePair> CustomTimerProperties::GetPrope
   std::vector<kodi::addon::PVRSettingKeyValuePair> customProps;
   GetCommonProperties(customProps, rec);
 
-  if (customProps.size() < m_propIds.size())
-    Logger::Log(LogLevel::LEVEL_ERROR, "Not all properties handled!");
-
   return customProps;
 }
 
@@ -63,9 +60,6 @@ std::vector<kodi::addon::PVRSettingKeyValuePair> CustomTimerProperties::GetPrope
     }
   }
 
-  if (customProps.size() < m_propIds.size())
-    Logger::Log(LogLevel::LEVEL_ERROR, "Not all properties handled!");
-
   return customProps;
 }