Create RDS stream only if audio stream actually contains RDS data. #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksooo
force-pushed
the
rds-support-dyn
branch
from
293fbc6
to
95341ba
Compare
ksooo
force-pushed
the
rds-support-dyn
branch
from
95341ba
to
bda6b76
Compare
Jalle19
approved these changes
Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to revise the first RDS implementation a bit, because Kodi makes asumptions on presense of RDS stream even if it never delivers data. First approach "blindly" added an RDS stream for every MPEG2AUDIO stream announced by tvh, but not every MPEG2AUDIO stream actually contains RDS data.
It's actually a more clean approach now, as we only announce an RDS stream to Kodi if there are actually RDS data available.
@Jalle19 good to go?