Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Predictive tuning: Fix crash because of an invalid comparator #663

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Predictive tuning: Fix crash because of an invalid comparator #663

merged 2 commits into from
Apr 24, 2024

Conversation

ace20022
Copy link
Contributor

@ace20022 ace20022 commented Apr 22, 2024 •
edited
Loading

The compare function violated the antisymmetry. (Counter)example:
grafik

@ksooo
Copy link
Member

ksooo commented Apr 22, 2024 •
edited
Loading

Please provide instructions how to reproduce the crash.

EDIT: Alright, got it.

ksooo
ksooo requested changes Apr 22, 2024
View reviewed changes
Copy link
Member

@ksooo ksooo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code change is okay. Thanks.
Please update minor version number in addon.xml.in and changelog.txt, then we can release a new add-on version.

ksooo
ksooo approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@ksooo ksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@ksooo ksooo merged commit 6c5564f into kodi-pvr:Omega Apr 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksooo ksooo ksooo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ace20022 @ksooo