Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for Piers #269

Merged
merged 5 commits into from
Sep 7, 2024
Merged

Changes for Piers #269

merged 5 commits into from
Sep 7, 2024

Conversation

emveepee
Copy link
Collaborator

  • incorporate changes from PR 266 Omega final.
  • reset to optional minimum inputstream adaptive.
  • NextPVR has no group API calls. Cache and compress channel list to avoid extra downloads. Compress to save on disk for large IPTV channel lists with zlib potential future use with VOD
  • update to tinyxml2 version 10 used by Kodi

@emveepee emveepee force-pushed the piersport branch 2 times, most recently from b37adbc to d9ad0e0 Compare July 29, 2024 11:44
@emveepee emveepee force-pushed the piersport branch 4 times, most recently from 4f0a3a2 to 357fd3c Compare August 14, 2024 15:06
@emveepee
Copy link
Collaborator Author

@ksooo @phunkyfish could you please review.

@phunkyfish
Copy link
Member

There is a merge commit that should not be there. Then two commits with the same name that doesn't make sense. Can you clean that up?

@emveepee
Copy link
Collaborator Author

There is a merge commit that should not be there. Then two commits with the same name that doesn't make sense. Can you clean that up?

@phunkyfish yeah I couldn't figure out how to merge in those conflicted files that got changed twice after I started this. Can you help me out on how to do that?

@phunkyfish
Copy link
Member

I would just create a new branch and cherry pick the commits that you need. Then rename the branch and push it to the PR

@emveepee
Copy link
Collaborator Author

emveepee commented Aug 17, 2024

I would just create a new branch and cherry pick the commits that you need. Then rename the branch and push it to the PR

Could I go back to my original approach noting I should have named commits differently, Hopefully the following changes are clearer.

@ksooo
Copy link
Member

ksooo commented Aug 17, 2024

The merge commit "Update to PVR API 9" should be renoved from this PR.

src/BackendRequest.cpp Outdated Show resolved Hide resolved
src/BackendRequest.cpp Outdated Show resolved Hide resolved
src/BackendRequest.h Outdated Show resolved Hide resolved
src/EPG.cpp Outdated Show resolved Hide resolved
src/pvrclient-nextpvr.cpp Outdated Show resolved Hide resolved
@emveepee emveepee force-pushed the piersport branch 2 times, most recently from 76ae308 to e11c2f4 Compare August 17, 2024 17:00
@emveepee
Copy link
Collaborator Author

The merge commit "Update to PVR API 9" should be renoved from this PR.

@phunkyfish @ksooo I redid all the commits and was able to rebase correctly to remove this. I have one small change to make to change Channels.cpp back to the original filename on line 356 "/public/LiveStreams.xml"; and will do that after the changes are approved or if the review finds anything else.

pvr.nextpvr/changelog.txt Outdated Show resolved Hide resolved
src/Recordings.cpp Outdated Show resolved Hide resolved
src/buffers/ClientTimeshift.h Outdated Show resolved Hide resolved
src/EPG.cpp Outdated Show resolved Hide resolved
src/EPG.cpp Outdated Show resolved Hide resolved
src/EPG.cpp Outdated Show resolved Hide resolved
src/Recordings.cpp Outdated Show resolved Hide resolved
src/Recordings.cpp Outdated Show resolved Hide resolved
src/Recordings.cpp Show resolved Hide resolved
src/EPG.cpp Show resolved Hide resolved
Start timeshift in real time mode.  Low bit radio was taking to long to buffer. From PR 266
Remove duplicated series information from recordings, timer and EPG.  Parse episode display information from the description. From PR kodi-pvr#266
NextPVR has no group API calls.  Cache and compress channel list to avoid extra downloads.  Compress to save on disk for large IPTV channel lists with zlib potential future use with VOD.  Also update to same tinyxml2 version used by Kodi
Copy link
Member

@phunkyfish phunkyfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see all the comments have been addressed. Just one thing to change.

pvr.nextpvr/addon.xml.in Outdated Show resolved Hide resolved
PVR 9 allows populating EpisodePart on recordings.  Update package for release
Since Matrix the wrong  XML tag was being extracted so the genre colour and genre text have been incorrect.  Will backport to Omega with changes from @ksooo improving the port from Omega in this PR.
@sub3 sub3 merged commit 0f36993 into kodi-pvr:Piers Sep 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants