Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cli argument for wandb session name #1032

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

nirweingarten
Copy link
Contributor

Adds a command line argument that allows users to specify the wandb session name of their run.
Without this feature session names are not indicative.
While it is possible to fetch logger kwargs from a configuration toml this is cumbersome when sessions names are created in run time, which is very often the case.

This PR was first opened to the kohya_ss repo and now reopend in the sd_scripts repo as required.
bmaltais/kohya_ss#1825

@kohya-ss
Copy link
Owner

kohya-ss commented Jan 4, 2024

Thank you for this! I don't use wandb personally, but this seems to be good.

I will update other training scripts as same as this, after merging.

@kohya-ss kohya-ss merged commit 4f93bf1 into kohya-ss:main Jan 4, 2024
1 check passed
@nirweingarten
Copy link
Contributor Author

@bmaltais thank you for creating and maintaining this beautiful repo :)

@FurkanGozukara
Copy link

@bmaltais thank you for creating and maintaining this beautiful repo :)

yes he is amazing

kohya-ss added a commit that referenced this pull request Jan 14, 2024
Disty0 pushed a commit to Disty0/sd-scripts that referenced this pull request Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants