forked from rubocop/rubocop
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix a false positive for
Style/DoubleNegation
This PR fixes the following false positive for `Style/DoubleNegation` when inside returned conditional clauses with Ruby 2.7's pattern matching. The following is a reproduction case. ```ruby def foo? case condition in foo !!foo in bar !!bar else !!baz end end ``` It is expected that an offense will not be registered, but in actually an offense will be registered. ```console % bundle exec rubocop --only Style/DoubleNegation (snip) Inspecting 2 files C. Offenses: example.rb:4:5: C: [Correctable] Style/DoubleNegation: Avoid the use of double negation (!!). !!foo ^ example.rb:6:5: C: [Correctable] Style/DoubleNegation: Avoid the use of double negation (!!). !!bar ^ 2 files inspected, 2 offenses detected, 2 offenses auto-correctable ``` This is a follow-up to the same issue as rubocop#10474 and requires RuboCop AST 1.7 to fix. Therefore it bumps RuboCop AST required to use rubocop/rubocop-ast#227 to 1.7 or higher.
- Loading branch information
Showing
3 changed files
with
77 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
* [#10518](https://github.com/rubocop/rubocop/pull/10518): Fix a false positive for `Style/DoubleNegation` when inside returned conditional clauses with Ruby 2.7's pattern matching. ([@koic][]) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters