ROTG: fix issue with return type of sqrt

Kokkos::sqrt(Kokkos::complex<>) returns a Kokkos::complex<> so in this case we need to take the module of that since we want a magnitude_type.
kokkos · Sep 15, 2022 · 26f062f · 26f062f
1 parent 3821780
commit 26f062f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/blas/impl/KokkosBlas1_rotg_impl.hpp b/src/blas/impl/KokkosBlas1_rotg_impl.hpp
@@ -106,8 +106,9 @@ void Rotg_Invoke(Scalar& a, Scalar& b,
   } else {
     const Scalar scaled_a = Kokkos::abs(a / numerical_scaling);
     const Scalar scaled_b = Kokkos::abs(b / numerical_scaling);
-    mag_type norm = Kokkos::sqrt(scaled_a * scaled_a + scaled_b * scaled_b) *
-                    numerical_scaling;
+    mag_type norm =
+        Kokkos::abs(Kokkos::sqrt(scaled_a * scaled_a + scaled_b * scaled_b)) *
+        numerical_scaling;
     Scalar unit_a = a / Kokkos::abs(a);
     c             = Kokkos::abs(a) / norm;
     s             = unit_a * Kokkos::conj(b) / norm;

diff --git a/unit_test/blas/Test_Blas1_rotg.hpp b/unit_test/blas/Test_Blas1_rotg.hpp
@@ -10,7 +10,8 @@ void test_rotg_impl(const Scalar a_in, const Scalar b_in) {
   // Initialize inputs/outputs
   Scalar a = a_in;
   Scalar b = b_in;
-  Scalar c = zero, s = zero;
+  magnitude_type c = Kokkos::ArithTraits<magnitude_type>::zero();
+  Scalar s = zero;
 
   KokkosBlas::rotg(a, b, c, s);