Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_spmv_bsrmatrix_controls_pattern incorrect epsilon? #1792

Closed
e10harvey opened this issue Apr 13, 2023 · 3 comments
Closed

test_spmv_bsrmatrix_controls_pattern incorrect epsilon? #1792

e10harvey opened this issue Apr 13, 2023 · 3 comments
Assignees
Labels

Comments

@e10harvey
Copy link
Contributor

In #1774, I noticed that the epsilon for this test is always using the float16 epsilon while it looks like this test runs for all types: float, double, etc. Shouldn't epsilon be:

static_cast<double>(
        std::numeric_limits<typename y_view_t::value_type>::epsilon());

Instead of

static_cast<double>(
        std::numeric_limits<Kokkos::Experimental::half_t>::epsilon());

in Test_sparse_spmv.hpp?

@e10harvey
Copy link
Contributor Author

Relevant discussion thread: #1774 (comment)

@cwpearson
Copy link
Contributor

The float16 tolerance should only be used when the algorithm under test is the tensor core algorithm. I wonder if this slipped through a refactor somehow.

@cwpearson
Copy link
Contributor

This is resolved by removing the code in #1922

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants