Remove old half-precision arith traits #1774
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight to start: Total Wait = 3603
|
|
@ndellingwood, @dalg24: Should the constants from KokkosKernels_Half.hpp be decorated with [[deprecated]] for awhile before removal? |
How would you go about emitting deprecation warnings for them? |
brian-kelley
approved these changes
Apr 10, 2023
|
Everything looks fine to me. I think our policy is that we're free to change or remove anything in If you did want to give users a warning first, |
lucbv
approved these changes
Apr 10, 2023
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930_Tpls_CLANG13CUDA10
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL19
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_CLANG1001
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_A64FX_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_VEGA908_ROCM520
Jenkins Parameters
Using Repos:
Pull Request Author: e10harvey |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930_Tpls_CLANG13CUDA10
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL19
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_CLANG1001
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_A64FX_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_VEGA908_ROCM520
Jenkins Parameters
Console Output (last 100 lines) : KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight # 488 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930_Tpls_CLANG13CUDA10 # 93 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_GCC1020 # 123 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_GCC1020_Light_LayoutRight # 393 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_Tpls_GCC1020 # 354 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_Tpls_INTEL19 # 443 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_CLANG1001 # 496 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110 # 297 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_A64FX_GCC1020 # 292 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_VEGA908_ROCM520 # 295 (click to expand) |
|
This requires half_t and bhalf_t overloads of the mathematical functions in Kokkos Core. |
cwpearson
approved these changes
Apr 11, 2023
e10harvey
commented
Apr 13, 2023
| @@ -1450,8 +1450,7 @@ void test_spmv_bsrmatrix_controls_pattern( | |||
| // for CUDA 9, Kokkos half is actually float. However, the tensor core SpMV | |||
| // uses CUDA's half type, not Kokkos, so we still need a reduced precision | |||
| // test. | |||
| double eps = | |||
| 2 * KOKKOSKERNELS_IMPL_FP16_EPSILON * KOKKOSKERNELS_IMPL_FP16_RADIX; | |||
| double eps = std::numeric_limits<Kokkos::Experimental::half_t>::epsilon(); | |||
There was a problem hiding this comment.
@cwpearson, @brian-kelley: Shouldn't this epsilon from the test_y::value_type...?
There was a problem hiding this comment.
@e10harvey Yeah, I don't see why this should be hardcoded to the epsilon for half_t. Following up the calls, this test function gets called with all scalar types.
If tensor-core spmv needs a larger epsilon, that should be detected and handled here, rather than increasing the epsilon in general.
There was a problem hiding this comment.
Yes, I would be okay with hlaf_t if the type was clearly hard coded inside the function but here it is implicitly assumed that the control structure will use the tensor core unit and that all tensor core unit are (and always will?) use half precision. This needs to be reworked a bit
There was a problem hiding this comment.
@cwpearson: Will all the tensor core units always use half precision here?
There was a problem hiding this comment.
It's true that the tensor cores on volta always use half precision, however, I agree that this is not the right place to be setting this tolerance value. It should only be this looser tolerance when the algorithm is set to the tensor core algorithm
lucbv
requested changes
May 20, 2023
There was a problem hiding this comment.
@e10harvey when the Kokkos Core PRs are merged, can you update this PR to keep it compatible with building against Kokkos 4.0.0 with something like this:
#if KOKKOS_VERSION >= 40099
// New version
#else
// Old version
#endif
e10harvey
force-pushed
the
issue1414
branch
from
f77c3dc
to
19bf398
Compare
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job KokkosKernels_PullRequest_CLANG1001_solo to start: Total Wait = 3603
|
|
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
|
Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job KokkosKernels_PullRequest_CLANG1001_solo to start: Total Wait = 3603
|
@lucbv: Do you still want that done given that this is all in the experimental namesspace? Doing his will re-introduce the old arith traits code and increase the team's maintenance burden. |
|
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
|
Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job KokkosKernels_PullRequest_CLANG1001_solo to start: Total Wait = 3603
|
|
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930_Tpls_CLANG13CUDA10
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GNU1021
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GNU1021_Light_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GNU1021
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL19_solo
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_CLANG1001_solo
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_A64FX_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_VEGA908_ROCM520
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_VEGA908_Tpls_ROCM520
Jenkins Parameters
Using Repos:
Pull Request Author: e10harvey |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930_Tpls_CLANG13CUDA10
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GNU1021
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GNU1021_Light_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GNU1021
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL19_solo
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_CLANG1001_solo
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_A64FX_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_VEGA908_ROCM520
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_VEGA908_Tpls_ROCM520
Jenkins Parameters
Console Output (last 100 lines) : KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight # 911 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930_Tpls_CLANG13CUDA10 # 502 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_GNU1021 # 175 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_GNU1021_Light_LayoutRight # 174 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_Tpls_GNU1021 # 174 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_Tpls_INTEL19_solo # 180 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_CLANG1001_solo # 155 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110 # 666 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_A64FX_GCC1020 # 661 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_VEGA908_ROCM520 # 659 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_VEGA908_Tpls_ROCM520 # 180 (click to expand) |
|
Closing in favor of #1981 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1414.