Nightly Blas unit test failures with llvm/14, llvm/15 #2005
Comments
ndellingwood
changed the title
|
I tested and reproduced this with the following in debug builds:
The tests pass with sems-clang/11.0.1 The tests also pass in the cases above with debugging disabled |
ndellingwood
changed the title
|
For reference, the test seems to fail for non-power-of-two cases, ; I modified the test to run with 14 (fail) and 16 (pass); for the failing casesasum returned a value of 0
|
|
I have reproduced thin on blake - vectors of length I can't reproduce it on my workstation with the same LLVM and OpenBLAS. |
|
There have been some suspicious changes to asum and/or SPR since OpenBLAS 0.3.23:
|
|
Maybe try the latest OpenBLAS to see if the test passes with it? Alternatively you can try BLIS |
|
I noticed the test failures with sems-clang/14.0.6 without use of tpls (in addition to failures with various versions of openblas pre-0.3.25), just in case OpenBlas is a red herring |
|
Also, building with debug mode was a common factor, the tests passed for me with release mode with sems-clang/14.0.6 and llvm/15.0.7 |
|
I compiled a few of my own OpenBLAS on Blake (
I couldn't get the tests to fail with TPLs disabled, and the tests failed regardless of whether I use debug or release build. |
|
Openblas does define a version macro in #define OPENBLAS_VERSION " OpenBLAS 0.3.26 "It's possible to write a compile-time string parsing thing in C++ 17 to make a constexpr comparison with this version: #include <string_view>
#include <array>
#include <tuple>
#define OPENBLAS_VERSION " OpenBLAS 0.3.26 "
struct Version {
int major;
int minor;
int patch;
};
constexpr int parse_int(std::string_view sv) {
int result = 0;
for (char c : sv) {
if (c >= '0' && c <= '9') {
result = result * 10 + (c - '0');
} else {
break;
}
}
return result;
}
constexpr Version parse_version(std::string_view sv) {
Version v{0, 0, 0};
size_t start = sv.find_first_of("0123456789");
if (start == std::string_view::npos) return v;
size_t end = sv.find_first_not_of("0123456789", start);
v.major = parse_int(sv.substr(start, end - start));
start = sv.find_first_of("0123456789", end);
if (start == std::string_view::npos) return v;
end = sv.find_first_not_of("0123456789", start);
v.minor = parse_int(sv.substr(start, end - start));
start = sv.find_first_of("0123456789", end);
if (start == std::string_view::npos) return v;
end = sv.find_first_not_of("0123456789", start);
v.patch = parse_int(sv.substr(start, end - start));
return v;
}
constexpr bool operator>=(const Version& lhs, const Version& rhs) {
return std::tie(lhs.major, lhs.minor, lhs.patch) >= std::tie(rhs.major, rhs.minor, rhs.patch);
}
template <size_t N>
constexpr bool check_openblas_version_gte(const char (&version)[N], const Version& min_version) {
return parse_version(std::string_view(version, N - 1)) >= min_version;
}
int main(void) {
static_assert(check_openblas_version_gte(OPENBLAS_VERSION, Version{0, 3, 27}), "OpenBLAS version is too old");
}
However, I think we'd have to have a separate configure-time check to see if our host blas is OpenBLAS or not, and if so, include the appropriate header file that defines |
|
And/or a workaround like this: template <>
double HostBlas<std::complex<double> >::asum(KK_INT n, const std::complex<double>* x, KK_INT x_inc) {
// workaround for clang 15.0.7 + openblas 0.3.23 + sapphire rapids
// this combo doesn't work for vectors < 16 long, so copy into a vector of length 16
// and put zeros in the rest
std::complex<double> scratch[16];
const std::complex<double> *p;
if (n > 0 && n < 16) {
for (int i = 0; i < 16; ++i) {
if (i < n) {
scratch[i] = x[i];
} else {
scratch[i] = std::complex<double>{0,0};
}
}
p = scratch;
n = 16;
} else {
p = x;
}
return F77_FUNC_DZASUM(&n, p, &x_inc);
} |
The following Blas unit tests fail in Serial builds with debugging when compiled with llvm/15.0.7, openblas/0.3.23
KokkosKernels_blas_serial
Reproducer (blake "all" queue):
salloc -N 1 -p all module purge module load cmake llvm openblas/0.3.23 $KOKKOSKERNELS_PATH/cm_generate_makefile.bash --with-serial --compiler=clang++ --with-tpls=blas,lapack --debug --with-scalars=complex_double,doublellvm/15.0.7 is the only version available on blake, but I'll test with different versions on another machine
The text was updated successfully, but these errors were encountered: