Add volta70 AT2 checks #2325
Open
Add volta70 AT2 checks #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kokkos-devops-admin
added
the
AT2-SPECIAL-APPROVAL
kokkos-devops-admin
added
AT2-SPECIAL-APPROVAL
kokkos-devops-admin
added
AT2-SPECIAL-APPROVAL
kokkos-devops-admin
added
AT2-SPECIAL-APPROVAL
kokkos-devops-admin
added
AT2-SPECIAL-APPROVAL
kokkos-devops-admin
added
AT2-SPECIAL-APPROVAL
lucbv
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
This looks reasonable although one thing that would be good is to use the latest release of Kokkos Core, 4.4.00 at this time, as we do with the current auto-tester. I believe changing from ref: ${{ github.base_ref} to the 4.4.0 tag might be the way to handle that
|
Also should we actually run the volta 70 jobs to check that they run and pass before merging? |
kokkos-devops-admin
added
AT2-SPECIAL-APPROVAL
Yea, the CLANG13CUDA check does fail a few tests with #2005. |
kokkos-devops-admin
added
AT2-SPECIAL-APPROVAL
kokkos-devops-admin
added
AT2-SPECIAL-APPROVAL
|
@ndellingwood, @lucbv: I'd like to get this PR merged, do you know the ctest regex syntax that's needed to exclude the failing tests? e.g., see 8d9a0eb |
kokkos-devops-admin
added
AT2-SPECIAL-APPROVAL
kokkos-devops-admin
added
AT2-SPECIAL-APPROVAL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.