979-shortenwinnames #1000
Open
979-shortenwinnames #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nces of MEMSPACE_HOSTSPACE with HOSTSP to trim down on some of the long variable names. Similar replacements made for KokkosKernels_config.h.in
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
This looks newer than related #395 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch aims to trim down the length of some of the variable names used in kokkos-kernels/cmake, as on Windows there are link errors if the names generated in CMake are too long. Currently, we replace instances of MEMSPACE_HOSTSPACE to HOSTSP.
We are submitting this pull request to initiate a discussion on the desired approach. We note that TPetra does something similar, but with shorter instance names, and there are no problems in building TPetra.