KokkosKernels: Fix install( ... DESTINATION ... ) dir (#10810) #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This correctly uses just ${${PROJECT_NAME}_INSTALL_INCLUDE_DIR} which if
relative, CMake assumes is relative to ${CMAKE_INSTALL_PREFIX}. Fixing this
means that:
cmake --install . --prefix <some-other-prefix>
works correctly.
|
@lucbv, what does that mean when you assign a PR to a GitHub user who is not a member of the GitHub project? |
|
@bartlettroscoe since you wrote this PR I assume you are willing to do modifications to it if something fail in the auto-tester? |
Sure. Just wanted to know what that meant. |
ndellingwood
approved these changes
Aug 15, 2022
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matching PR for #1496 that brings this fix into the branch
release-candidate-3.7.00.