Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cuda_data_type_from to return CUDA_C_64F for Kokkos::complex<double> #1604

Merged
merged 1 commit into from
Nov 26, 2022
Merged

Fix cuda_data_type_from to return CUDA_C_64F for Kokkos::complex<double> #1604

merged 1 commit into from
Nov 26, 2022

Conversation

vqd8a
Copy link
Contributor

@vqd8a vqd8a commented Nov 25, 2022

Just a minor change to fix the typo in cuda_data_type_from to return CUDA_C_64F for Kokkos::complex<double>

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request.

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930

  • Build Num: 167
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix-typo-cuda-data-type-from
KOKKOSKERNELS_SOURCE_REPO https://github.com/vqd8a/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 19cec1c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA ab7e6c7
PR_LABELS
PULLREQUESTNUM 1604
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

  • Build Num: 175
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix-typo-cuda-data-type-from
KOKKOSKERNELS_SOURCE_REPO https://github.com/vqd8a/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 19cec1c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA ab7e6c7
PR_LABELS
PULLREQUESTNUM 1604
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

  • Build Num: 128
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix-typo-cuda-data-type-from
KOKKOSKERNELS_SOURCE_REPO https://github.com/vqd8a/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 19cec1c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA ab7e6c7
PR_LABELS
PULLREQUESTNUM 1604
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

  • Build Num: 127
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix-typo-cuda-data-type-from
KOKKOSKERNELS_SOURCE_REPO https://github.com/vqd8a/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 19cec1c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA ab7e6c7
PR_LABELS
PULLREQUESTNUM 1604
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

  • Build Num: 90
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix-typo-cuda-data-type-from
KOKKOSKERNELS_SOURCE_REPO https://github.com/vqd8a/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 19cec1c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA ab7e6c7
PR_LABELS
PULLREQUESTNUM 1604
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

  • Build Num: 177
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix-typo-cuda-data-type-from
KOKKOSKERNELS_SOURCE_REPO https://github.com/vqd8a/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 19cec1c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA ab7e6c7
PR_LABELS
PULLREQUESTNUM 1604
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 226
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix-typo-cuda-data-type-from
KOKKOSKERNELS_SOURCE_REPO https://github.com/vqd8a/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 19cec1c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA ab7e6c7
PR_LABELS
PULLREQUESTNUM 1604
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG13CUDA10

  • Build Num: 112
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix-typo-cuda-data-type-from
KOKKOSKERNELS_SOURCE_REPO https://github.com/vqd8a/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 19cec1c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA ab7e6c7
PR_LABELS
PULLREQUESTNUM 1604
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

  • Build Num: 6
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix-typo-cuda-data-type-from
KOKKOSKERNELS_SOURCE_REPO https://github.com/vqd8a/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 19cec1c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA ab7e6c7
PR_LABELS
PULLREQUESTNUM 1604
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

  • Build Num: 6
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix-typo-cuda-data-type-from
KOKKOSKERNELS_SOURCE_REPO https://github.com/vqd8a/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 19cec1c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA ab7e6c7
PR_LABELS
PULLREQUESTNUM 1604
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_VEGA908_ROCM520

  • Build Num: 13
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix-typo-cuda-data-type-from
KOKKOSKERNELS_SOURCE_REPO https://github.com/vqd8a/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 19cec1c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA ab7e6c7
PR_LABELS
PULLREQUESTNUM 1604
TEST_REPO_ALIAS KOKKOSKERNELS

Using Repos:

Repo: KOKKOSKERNELS (vqd8a/kokkos-kernels)
  • Branch: fix-typo-cuda-data-type-from
  • SHA: 19cec1c
  • Mode: TEST_REPO

Pull Request Author: vqd8a

lucbv
lucbv approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@lucbv lucbv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that makes a lot of sense!

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930

  • Build Num: 167
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix-typo-cuda-data-type-from
KOKKOSKERNELS_SOURCE_REPO https://github.com/vqd8a/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 19cec1c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA ab7e6c7
PR_LABELS
PULLREQUESTNUM 1604
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight

  • Build Num: 175
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix-typo-cuda-data-type-from
KOKKOSKERNELS_SOURCE_REPO https://github.com/vqd8a/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 19cec1c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA ab7e6c7
PR_LABELS
PULLREQUESTNUM 1604
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020

  • Build Num: 128
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix-typo-cuda-data-type-from
KOKKOSKERNELS_SOURCE_REPO https://github.com/vqd8a/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 19cec1c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA ab7e6c7
PR_LABELS
PULLREQUESTNUM 1604
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight

  • Build Num: 127
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix-typo-cuda-data-type-from
KOKKOSKERNELS_SOURCE_REPO https://github.com/vqd8a/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 19cec1c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA ab7e6c7
PR_LABELS
PULLREQUESTNUM 1604
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_GCC1020

  • Build Num: 90
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix-typo-cuda-data-type-from
KOKKOSKERNELS_SOURCE_REPO https://github.com/vqd8a/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 19cec1c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA ab7e6c7
PR_LABELS
PULLREQUESTNUM 1604
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_Tpls_INTEL19

  • Build Num: 177
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix-typo-cuda-data-type-from
KOKKOSKERNELS_SOURCE_REPO https://github.com/vqd8a/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 19cec1c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA ab7e6c7
PR_LABELS
PULLREQUESTNUM 1604
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG1001

  • Build Num: 226
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix-typo-cuda-data-type-from
KOKKOSKERNELS_SOURCE_REPO https://github.com/vqd8a/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 19cec1c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA ab7e6c7
PR_LABELS
PULLREQUESTNUM 1604
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_CLANG13CUDA10

  • Build Num: 112
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix-typo-cuda-data-type-from
KOKKOSKERNELS_SOURCE_REPO https://github.com/vqd8a/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 19cec1c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA ab7e6c7
PR_LABELS
PULLREQUESTNUM 1604
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110

  • Build Num: 6
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix-typo-cuda-data-type-from
KOKKOSKERNELS_SOURCE_REPO https://github.com/vqd8a/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 19cec1c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA ab7e6c7
PR_LABELS
PULLREQUESTNUM 1604
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_A64FX_GCC1020

  • Build Num: 6
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix-typo-cuda-data-type-from
KOKKOSKERNELS_SOURCE_REPO https://github.com/vqd8a/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 19cec1c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA ab7e6c7
PR_LABELS
PULLREQUESTNUM 1604
TEST_REPO_ALIAS KOKKOSKERNELS

Build Information

Test Name: KokkosKernels_PullRequest_VEGA908_ROCM520

  • Build Num: 13
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
KOKKOSKERNELS_SOURCE_BRANCH fix-typo-cuda-data-type-from
KOKKOSKERNELS_SOURCE_REPO https://github.com/vqd8a/kokkos-kernels
KOKKOSKERNELS_SOURCE_SHA 19cec1c
KOKKOSKERNELS_TARGET_BRANCH develop
KOKKOSKERNELS_TARGET_REPO https://github.com/kokkos/kokkos-kernels
KOKKOSKERNELS_TARGET_SHA ab7e6c7
PR_LABELS
PULLREQUESTNUM 1604
TEST_REPO_ALIAS KOKKOSKERNELS

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ lucbv ]!

@kokkos-devops-admin
Copy link

Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - This Repo does not support Automerge

@lucbv lucbv merged commit 7d05d9d into kokkos:develop Nov 26, 2022
@lucbv lucbv mentioned this pull request Nov 28, 2022
Closed
@ndellingwood
Copy link
Contributor

This will need cherry-pick to release-candidate-3.7.01

ndellingwood pushed a commit that referenced this pull request Nov 29, 2022
@lucbv @ndellingwood
Merge pull request #1604 from vqd8a/fix-typo-cuda-data-type-from
023898a 
Fix cuda_data_type_from to return CUDA_C_64F for Kokkos::complex<double>

(cherry picked from commit 7d05d9d)
@ndellingwood
Copy link
Contributor

Cherry-picked to release-candidate-3.7.01 SHA 023898a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucbv lucbv lucbv approved these changes

@brian-kelley brian-kelley Awaiting requested review from brian-kelley

Assignees
No one assigned
Labels
patch-release-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vqd8a @kokkos-devops-admin @ndellingwood @lucbv