#5: added TplsVersion file and print methods #1693
Conversation
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
| #include <iostream> | ||
|
|
||
| namespace KokkosKernels { | ||
| namespace Impl { | ||
|
|
||
| inline void print_cublas_version(std::ostream& os) { |
There was a problem hiding this comment.
i would call this: print_cublas_version_else_no_if_disabled so that is conveys that it prints something in both cases
There was a problem hiding this comment.
I went with print_cublas_version_if_enabled to keep the name's length in check 😉
There was a problem hiding this comment.
I still think thatprint_cublas_version_if_enabled gives the idea that if enabled, print version but does not convey anything about what happens if not enabled. but since this might only be used for the print config, I think i can let it go
| #endif | ||
| } | ||
|
|
||
| inline void print_cusparse_version(std::ostream& os) { |
There was a problem hiding this comment.
Renamed to print_cusparse_version_if_enabled.
|
the other minor comment I have is to maybe rename the file |
cz4rs
force-pushed
the
5-print-get-CUSPARSE-CUBLAS-versions
branch
from
dc3476b
to
9831212
Compare
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
cz4rs
force-pushed
the
5-print-get-CUSPARSE-CUBLAS-versions
branch
from
9831212
to
7f9d09d
Compare
|
@fnrizzi addressed the comments and rebased, I think this is ready to go. |
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
@cz4rs can you please (1) make it ready for review and (2) add Luc and Carl @cwpearson as reviewer |
Actually, I cannot (neither |
|
@mperrinel can you please do #1693 (comment) |
|
@fnrizzi partially done. I cannot add reviewers. |
kokkos-devops-admin
removed
the
AT: PRE-TEST INSPECTED
|
Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL19
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_CLANG1001
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_CLANG13CUDA10
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_VEGA908_ROCM520
Jenkins Parameters
Using Repos:
Pull Request Author: mperrinel |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL19
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_CLANG1001
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_CLANG13CUDA10
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_VEGA908_ROCM520
Jenkins Parameters
Console Output (last 100 lines) : KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930 # 376 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight # 381 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_GCC1020 # 23 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_GCC1020_Light_LayoutRight # 294 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_Tpls_GCC1020 # 257 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_Tpls_INTEL19 # 344 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_CLANG1001 # 396 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_CLANG13CUDA10 # 308 (click to expand)Console Output (last 100 lines) : KokkosKernels_PullRequest_VEGA908_ROCM520 # 197 (click to expand) |
| std::stringstream ss; | ||
|
|
||
| ss << CUBLAS_VER_MAJOR << "." << CUBLAS_VER_MINOR << "." << CUBLAS_VER_PATCH | ||
| << CUBLAS_VER_BUILD; |
There was a problem hiding this comment.
KokkosKernels_PullRequest_CLANG13CUDA10 build fails with:
(...)/common/src/KokkosKernels_TplsVersion.hpp:39:9: error: use of undeclared identifier 'CUBLAS_VER_BUILD'
<< CUBLAS_VER_BUILD;
There was a problem hiding this comment.
This seems to be present in CUDA-10.2. Investigating...
There was a problem hiding this comment.
Actually we are building against CUDA-10.1.243 which might not be the right thing to do... but in that version of CUDA the variable is not defined, however in CUDA-10.2.089 it is defined indeed
kokkos-devops-admin
removed
the
AT: PRE-TEST INSPECTED
|
Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed. |
CUBLAS_VER_BUILD is not defined in CUDA-10.1.243.
cz4rs
force-pushed
the
5-print-get-CUSPARSE-CUBLAS-versions
branch
from
96a3689
to
323cefa
Compare
kokkos-devops-admin
removed
the
AT: PRE-TEST INSPECTED
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
@cwpearson let us know if you want more changes |
kokkos-devops-admin
removed
the
AT: PRE-TEST INSPECTED
|
Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; This inspection will remain valid until a new commit to source branch is performed. |
|
Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight to start: Total Wait = 3603
|
|
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
|
Status Flag 'Pull Request AutoTester' - Failure: Timed out waiting for job KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930_Tpls_CLANG13CUDA10 to start: Total Wait = 3603
|
|
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930_Tpls_CLANG13CUDA10
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL19
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_CLANG1001
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_A64FX_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_VEGA908_ROCM520
Jenkins Parameters
Using Repos:
Pull Request Author: mperrinel |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: KokkosKernels_PullRequest_CUDA11_CUDA11_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC930_Light_Tpls_GCC930_Tpls_CLANG13CUDA10
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_GCC1020_Light_LayoutRight
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_Tpls_INTEL19
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_CLANG1001
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_A64FX_Tpls_ARMPL2110
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_A64FX_GCC1020
Jenkins Parameters
Build InformationTest Name: KokkosKernels_PullRequest_VEGA908_ROCM520
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
|
@cwpearson when you have a minute, please gives this another look |
This PR provides a way to get and print CUBLAS and CUSPARSE TPLs version.
The idea is to print the TPL version instead of 'yes' when the TPL is activated. We still print 'no' if the TPL is not activated.
extract of the test with CUBLAS and CUSPARSE TPLs activated