Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master release 4.4.00 #2303

Merged
merged 401 commits into from
Aug 12, 2024
Merged

Master release 4.4.00 #2303

merged 401 commits into from
Aug 12, 2024

Conversation

ndellingwood
Copy link
Contributor

No description provided.

lucbv and others added 30 commits December 8, 2023 09:51
Link std::filesystem for IntelLLVM in perf_test/sparse
Resolve warnings in builds with c++20 support enabled:
"kokkos-kernels/sparse/impl/KokkosSparse_spmv_impl_merge.hpp:166:81: warning: implicit capture of 'this' via '[=]' is deprecated in C++20 [-Wdeprecated]"
Resolve warnings in builds with c++20 support enabled:
"kokkos-kernels/sparse/impl/KokkosSparse_par_ilut_numeric_impl.hpp(591):
warning #2908-D: the implicit by-copy capture of "this" is deprecated"
…this

Cleanup implicit capture of 'this' via '[=]' is deprecated in C++20 warnings
…lease

Async matrix release for MKL >= 2023.2 in SpMV
…n_fixes

ROCm 6 deprecation fixes for rocsparse
Correcting BLAS test failures with cuda when ETI_ONLY = OFF (issue kokkos#2061)
…tions

Support `CUBLAS_{LIBRARIES,LIBRARY_DIRS,INCLUDE_DIRS,ROOT}` and `KokkosKernels_CUBLAS_ROOT` CMake options
jgfouca and others added 8 commits August 7, 2024 12:46
* Some cleanup and refactoring

* First round of cleanup complete

* Fix a couple warnings

* formatting

* Cleanup progress

* Fixes

* Remove Upper/Lower TriLvlSchedTP2SolverFunctors

* Remove Upper/Lower single block functors

* Remove unused TriLvlSchedTP1SingleBlockFunctorDiagValues and merge upper/lower tri_solve_cg

* Merge two big upper/lower branch of tri_solve_chain

* Merge upper/lower tri_solve_streams

* progres

* progress

* Progress, test added

* progress and fixes

* prog

* prog but broken

* Prog with debug prints

* Remove extreme debug printing

* works

* all working

* Remove test mangling

* Switch over block spiluk precond test to use new block sptrsv

* More test cleanup

* Fixes for GPU warnings

* Conflicts resolved, still work needed

* builds

* Formatting

* Update work to latest format style

* Remove unused functions. Remove prints. Add barriers

* Minor fixes

* lset is not used

* Fix for clang

* formatting

* New impl approach

* Unset macro

* There's no reason to limit team-policy alg to MAX_VEC_SIZE

* formatting

* Add missing kokkos-inline-funcs

* Fix warnings

* format
The SYCL GEMV update has been reverted in a later PR as the fix required was for the GEMV algorithm in the Sparse namespace, also known as SpMV. The previous BLAS::gemv fix was reverted
@ndellingwood
Copy link
Contributor Author

Trilinos snapshot PR: trilinos/Trilinos#13334
Do not merge until confirmation that PR has passed testing and is approved

@ndellingwood
Copy link
Contributor Author

applied clang-format in f7df9ff , made a mistake during the revert of #2185

snapshot to Trilinos updated as well

@ndellingwood
Copy link
Contributor Author

ndellingwood commented Aug 8, 2024

updated the other yaml workflow files to use kokkos@4.3.01

snapshot to Trilinos updated as well

@ndellingwood
Copy link
Contributor Author

Some of the AT2 jobs fail with:

 A job started hook has been configured by the self-hosted runner administrator
Run '/home/runner/snl_verify.sh'
[2024-08-08T01:26:43Z INFO  github_api_requester] Success Status for user ndellingwood: 200 OK
[2024-08-08T01:26:45Z INFO  github_api_requester] Success Status for user lucbv: 200 OK
[2024-08-08T01:26:45Z INFO  github_api_requester] Success Status for user jgfouca: 200 OK
[2024-08-08T01:26:46Z ERROR github_api_requester] Failure Status for user rbberger: 404 Not Found
[2024-08-08T01:26:46Z INFO  verification::job_approver] found unapproved commit from committer: "rbberger"
[2024-08-08T01:26:46Z INFO  verification::job_approver] last unapproved commit made on: "2024-08-01 21:13:19"
[2024-08-08T01:26:56Z INFO  verification::job_approver] .github directory was modified, requiring special approval...
[2024-08-08T01:26:59Z ERROR verification::job_approver] AT2: latest special approval: No special approval found
[2024-08-08T01:26:59Z INFO  verification] Job is not approved
Error: Process completed with exit code 1.

@ndellingwood ndellingwood added the AT2-SPECIAL-APPROVAL Mark .github changes as approved. label Aug 8, 2024
@ndellingwood
Copy link
Contributor Author

After adding the AT2-SPECIAL-APPROVAL label for the file changes in .github, still seeing AT2 failures as follows:

 [2024-08-08T01:30:47Z INFO  github_api_requester] Success Status for user ndellingwood: 200 OK
[2024-08-08T01:30:49Z INFO  github_api_requester] Success Status for user lucbv: 200 OK
[2024-08-08T01:30:49Z INFO  github_api_requester] Success Status for user jgfouca: 200 OK
[2024-08-08T01:30:50Z ERROR github_api_requester] Failure Status for user rbberger: 404 Not Found
[2024-08-08T01:30:50Z INFO  verification::job_approver] found unapproved commit from committer: "rbberger"
[2024-08-08T01:30:50Z INFO  verification::job_approver] last unapproved commit made on: "2024-08-01 21:13:19"
[2024-08-08T01:30:59Z INFO  verification::job_approver] .github directory was modified, requiring special approval...
[2024-08-08T01:31:00Z INFO  github_api_requester] Success Status for user ndellingwood: 200 OK
[2024-08-08T01:31:00Z INFO  verification::job_approver] latest special approval: 2024-08-08T01:29:58
[2024-08-08T01:31:02Z INFO  verification::job_approver] AT2: Latest commit made on 2024-08-08T01:23:59Z
[2024-08-08T01:31:04Z INFO  verification::job_approver] found unapproved commit from committer: "rbberger"
[2024-08-08T01:31:04Z INFO  verification::job_approver] AT2: last unapproved commit: "2024-08-01 21:13:19"
[2024-08-08T01:31:05Z INFO  verification::job_approver] latest approval: "1950-01-01 00:00:00"
[2024-08-08T01:31:05Z ERROR verification::job_approver] AT2: latest_approval_date of 1950-01-01 00:00:00 is earlier than latest_unapproved_commit_date of 2024-08-01 21:13:19
[2024-08-08T01:31:05Z INFO  verification] Job is not approved
Error: Process completed with exit code 1.

@lucbv any suggestions?

ndellingwood and others added 5 commits August 8, 2024 14:57
…se artifacts (kokkos#2304)

This adds a workflow based on the scorecard recommendation for software provenance.
The workflow requires some manual actions to verify that the signiture in the release is correct.
Part of Kokkos C++ Performance Portability Programming EcoSystem 4.4
@ndellingwood
Copy link
Contributor Author

Just noting AT2 jobs will not run due to ERROR github_api_requester] Failure Status for user rbberger: 404 Not Found issues with external contributions

[2024-08-08T21:41:59Z ERROR github_api_requester] Failure Status for user rbberger: 404 Not Found
[2024-08-08T21:41:59Z INFO  verification::job_approver] found unapproved commit from committer: "rbberger"
[2024-08-08T21:41:59Z INFO  verification::job_approver] last unapproved commit made on: "2024-08-01 21:13:19"

This case is not covered by the AT2-SPECIAL-APPROVAL label

@ndellingwood
Copy link
Contributor Author

Trilinos PR passed trilinos/Trilinos#13334 , this is should be ready for final review

@ndellingwood
Copy link
Contributor Author

@lucbv this is ready to merge and tag

@lucbv lucbv merged commit 0608a33 into kokkos:master Aug 12, 2024
8 of 14 checks passed
@lucbv
Copy link
Contributor

lucbv commented Aug 12, 2024

Okay, approved and merged, will tag now

@ndellingwood ndellingwood deleted the master-release-4.4.00 branch September 12, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT2-SPECIAL-APPROVAL Mark .github changes as approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.