Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unit test headers installation #2334

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Fix unit test headers installation #2334

merged 1 commit into from
Dec 17, 2024

Conversation

tpadioleau
Copy link
Member

Closes #2332

@kokkos-devops-admin
Copy link

Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO INSPECTION HAS BEEN PERFORMED ON THIS PULL REQUEST! - This PR must be inspected by setting label 'AT: PRE-TEST INSPECTED'.

@lucbv
Copy link
Contributor

lucbv commented Sep 10, 2024

@tpadioleau the changes in your PR look reasonable to me, do you want to keep this as draft or shall we convert this to PR?
I am happy to review when you feel it is ready

@tpadioleau tpadioleau marked this pull request as ready for review September 11, 2024 06:16
@tpadioleau
Copy link
Member Author

tpadioleau commented Sep 11, 2024 •
edited
Loading

@tpadioleau the changes in your PR look reasonable to me, do you want to keep this as draft or shall we convert this to PR? I am happy to review when you feel it is ready

Yes I think it is fine. I could build the tests fine and the installation does not copy the test headers anymore. To be honest I just copy pasted what was done in the other directories without really understanding how it works :)

@lucbv lucbv self-requested a review September 12, 2024 17:19
@lucbv lucbv added the Cleanup Code maintenance that isn't a bugfix or new feature label Sep 12, 2024
@lucbv lucbv added the AT: PRE-TEST INSPECTED Mark this PR as approved for testing. label Sep 12, 2024
@tpadioleau tpadioleau force-pushed the fix-unit-test-headers-installation branch from 8b822d8 to d9dfb2e Compare December 16, 2024 19:16
@tpadioleau
Fix unit test headers installation
0872ed5 
Signed-off-by: Thomas Padioleau <thomas.padioleau@cea.fr>
@tpadioleau tpadioleau force-pushed the fix-unit-test-headers-installation branch from d9dfb2e to 0872ed5 Compare December 16, 2024 19:18
@lucbv
Copy link
Contributor

lucbv commented Dec 16, 2024

I will go ahead and test that locally then review and trigger CI, I should have been more on top of it...

@lucbv lucbv added AT2-CI-APPROVAL Approve CI to run at SNL and removed AT: PRE-TEST INSPECTED Mark this PR as approved for testing. labels Dec 17, 2024
@tpadioleau
Copy link
Member Author

I will go ahead and test that locally then review and trigger CI, I should have been more on top of it...

No problem!

@lucbv lucbv merged commit d96c6ee into kokkos:develop Dec 17, 2024
18 checks passed
@tpadioleau tpadioleau deleted the fix-unit-test-headers-installation branch December 17, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucbv lucbv lucbv approved these changes

Assignees
No one assigned
Labels
AT2-CI-APPROVAL Approve CI to run at SNL Cleanup Code maintenance that isn't a bugfix or new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit test headers are installed
3 participants
@tpadioleau @kokkos-devops-admin @lucbv