Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master release 4.4.01 #2337

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Conversation

ndellingwood
Copy link
Contributor

No description provided.

ndellingwood and others added 4 commits September 4, 2024 10:14
* Restore size_t as default offset, in Tribits builds (kokkos#2313)

If building KokkosKernels standalone, leave int as the default offset
(this was the case since kokkos#2140). But if building KokkosKernels as a
Trilinos/Tribits package, then make size_t the default offset because
this is what the Tpetra stack currently uses.

Signed-off-by: Brian Kelley <bmkelle@sandia.gov>

* Improve crs/bsr sorting performance (kokkos#2293)

* CRS sorting improvements

- Wrote bulk sort/permutation based sorting for CRS graph, matrix, and
  BSR matrix (bulk = one large sort of all the entries, using row-major
  dense index as keys)
  - This is more performant for imbalanced entries per row
- If matrix dimensions are too large to do bulk sort, fall back to
  sorting within each row with a thread.

* Add perf test for sort_crs_matrix
* sort_crs: improve parallel labels
* Work around kokkos issue 7036
* sort_crs: replace radix sort lambda with functor
(Lambda segfaults with nvcc+openmp)
---------
Signed-off-by: Brian Kelley <bmkelle@sandia.gov>

* SpAdd handle: delete sort_option getter/setter (kokkos#2296)

SpAdd handle was originally a copy-paste of the spgemm
handle way back in kokkos#122, and included get_sort_option() and
set_sort_option() from spgemm. But these try to use the member
bool sort_option, which doesn't exist. Somehow these functions never
produced compile errors until someone tried to call them.

* Improve GH action to produce release artifacts (kokkos#2312)

* coo2csr: add parens to function calls (kokkos#2318)

* Update changelog

* Update master_history.txt

* .github/workflows: Group jobs under common github-AT2 name (kokkos#2320)

* Update master_history.txt

---------

Signed-off-by: Brian Kelley <bmkelle@sandia.gov>
Co-authored-by: brian-kelley <bmkelle@sandia.gov>
Co-authored-by: Damien L-G <dalg24@gmail.com>
Co-authored-by: Carl Pearson <cwpearson@users.noreply.github.com>
Co-authored-by: Evan Harvey <57234914+e10harvey@users.noreply.github.com>
Part of Kokkos C++ Performance Portability Programming EcoSystem 4.4
@ndellingwood
Copy link
Contributor Author

Trilinos snapshot PR: trilinos/Trilinos#13446
Please do not merge until confirmation that PR has passed testing and is approved

@ndellingwood ndellingwood added the AT2-SPECIAL-APPROVAL Mark .github changes as approved. label Sep 12, 2024
@ndellingwood
Copy link
Contributor Author

Trilinos PR trilinos/Trilinos#13446 has passed

@ndellingwood
Copy link
Contributor Author

ndellingwood commented Sep 13, 2024

@lucbv ready for merge, the GA workflow should handle the tagging

Edit: Oop, I misunderstood the GA workflow; after tagging, it should generate the release artifacts

@lucbv
Copy link
Contributor

lucbv commented Sep 13, 2024

Yes, I will go ahead with the merge and do the final steps for tagging and checking the generated artifacts

@lucbv lucbv merged commit 0b43169 into kokkos:master Sep 13, 2024
11 checks passed
@ndellingwood ndellingwood deleted the master-release-4.4.01 branch September 17, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AT2-SPECIAL-APPROVAL Mark .github changes as approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants