-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gemv: call fallback impl in transpose mode with M==0 #551
Conversation
Address issue #540, problems with degenerate matrix cases when blas tpls enabled.
Detected with testing on Waterman and Blake testbeds when tpls are enabled (the default case in Trilinos), fix needed for 3.0 release. |
Tests now passing in Trilinos integration test builds on waterman. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the fall-back implementation host-only, or does it do the right thing with device Views?
@mhoemmen it will fallback in either case, I can update it to only do so for host execution. |
fix unused variable causing -Werror Fix for #539
@mhoemmen fixed with recent commit to not use fallback when Cuda is the exec space, thanks for the catch. |
Spot-check passed on kokkos-dev-2:
|
Address issue #540, problems with degenerate matrix cases when
blas tpls enabled.