Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix Converter: fixing issue with deallocation after Kokkos::fininalize() #882

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

lucbv
Copy link
Contributor

@lucbv lucbv commented Jan 28, 2021

Small change but we no longer get an error while running this.

…lize()

Small change but we no longer get an error while running this.
@lucbv lucbv added the Cleanup Code maintenance that isn't a bugfix or new feature label Jan 28, 2021
@lucbv lucbv self-assigned this Jan 28, 2021
Copy link
Contributor

@ndellingwood ndellingwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, simple change like you mentioned (adding scope guards), the extra line changes for the corresponding updated indentation

@lucbv
Copy link
Contributor Author

lucbv commented Jan 28, 2021

Just in case running the spot-check, it went well so let's merge!

#######################################################
PASSED TESTS
#######################################################
clang-8.0-Cuda_OpenMP-release build_time=729 run_time=142
clang-8.0-Pthread_Serial-release build_time=248 run_time=133
clang-9.0.0-Pthread-release build_time=163 run_time=62
clang-9.0.0-Serial-release build_time=164 run_time=50
cuda-10.1-Cuda_OpenMP-release build_time=927 run_time=143
cuda-11.0-Cuda_OpenMP-release build_time=937 run_time=141
cuda-9.2-Cuda_Serial-release build_time=894 run_time=223
gcc-7.3.0-OpenMP-release build_time=179 run_time=50
gcc-7.3.0-Pthread-release build_time=147 run_time=70
gcc-8.3.0-Serial-release build_time=171 run_time=58
gcc-9.1-OpenMP-release build_time=236 run_time=50
gcc-9.1-Serial-release build_time=201 run_time=57
intel-17.0.1-Serial-release build_time=430 run_time=54
intel-18.0.5-OpenMP-release build_time=727 run_time=50
intel-19.0.5-Pthread-release build_time=360 run_time=63

@lucbv lucbv merged commit 98e1c20 into kokkos:develop Jan 28, 2021
@lucbv lucbv deleted the Matrix_converter_update branch August 31, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Code maintenance that isn't a bugfix or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants