fix(frontend): 노트의 세부 옵션을 표시하는 더 보기! 버튼을 누를 수 없음

kokonect-link · Aug 30, 2024 · 72491fc · 72491fc
1 parent 78d315d
commit 72491fc
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 19 deletions.
diff --git a/CHANGELOG_CHERRYPICK.md b/CHANGELOG_CHERRYPICK.md
@@ -23,6 +23,16 @@ Misskey의 전체 변경 사항을 확인하려면, [CHANGELOG.md#2024xx](CHANGE
 # 릴리즈 노트
 이 문서는 CherryPick의 변경 사항만 포함합니다.
 
+## 4.x.x
+출시일: unreleased<br>
+기반 Misskey 버전: 2024.x.x<br>
+Misskey의 전체 변경 사항을 확인하려면, [CHANGELOG.md#2024xx](CHANGELOG.md#2024xx) 문서를 참고하십시오.
+
+### Client
+- Fix: 노트의 세부 옵션을 표시하는 `더 보기!` 버튼을 누를 수 없음
+
+---
+
 ## 4.11.0
 출시일: 2024/8/28<br>
 기반 Misskey 버전: 2024.8.0<br>

diff --git a/packages/frontend/src/scripts/get-note-menu.ts b/packages/frontend/src/scripts/get-note-menu.ts
@@ -490,10 +490,10 @@ export function getNoteMenu(props: {
 			}]
 			: []
 		),*/
-			...(appearNote.userId !== $i.id || (isRenote && props.note.userId !== $i.id) ? [
+			...(appearNote.userId !== $i.id || props.note.userId !== $i.id ? [
 				{ type: 'divider' },
 				appearNote.userId !== $i.id ? getAbuseNoteMenu(appearNote, i18n.ts.reportAbuse) : undefined,
-				isRenote && props.note.userId !== $i.id ? getAbuseNoteMenu(props.note, i18n.ts.reportAbuseRenote) : undefined,
+				props.note.userId !== $i.id ? getAbuseNoteMenu(props.note, i18n.ts.reportAbuseRenote) : undefined,
 			]
 			: []
 			),
@@ -622,15 +622,8 @@ export function getQuoteMenu(props: {
 	note: Misskey.entities.Note,
 	mock?: boolean;
 }) {
-	const isRenote = (
-		props.note.renote != null &&
-		props.note.text == null &&
-		props.note.fileIds &&
-		props.note.fileIds.length === 0 &&
-		props.note.poll == null
-	);
 	const menu: MenuItem[] = [];
-	const appearNote = isRenote ? props.note.renote as Misskey.entities.Note : props.note;
+	const appearNote = getAppearNote(props.note);
 
 	if (!appearNote.channel || appearNote.channel.allowRenoteToExternal) {
 		menu.push({
@@ -882,15 +875,7 @@ export async function getRenoteOnly(props: {
 	renoteButton: ShallowRef<HTMLElement | undefined>;
 	mock?: boolean;
 }) {
-	const isRenote = (
-		props.note.renote != null &&
-		props.note.text == null &&
-		props.note.fileIds &&
-		props.note.fileIds.length === 0 &&
-		props.note.poll == null
-	);
-
-	const appearNote = isRenote ? props.note.renote as Misskey.entities.Note : props.note;
+	const appearNote = getAppearNote(props.note);
 
 	if (defaultStore.state.showRenoteConfirmPopup) {
 		const { canceled } = await os.confirm({