Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in-feed post tweak options #495

Closed
1 task
breadguyyy opened this issue Sep 17, 2024 · 15 comments
Closed
1 task

in-feed post tweak options #495

breadguyyy opened this issue Sep 17, 2024 · 15 comments

Comments

@breadguyyy
Copy link

Summary

-option to show replied-to notes without grey filter
-option to collapse replied-to notes in feed
-option to always open the full conversation when opening a post
-option to always uncollapse CWs
-option to always uncollapse long posts

Purpose

adds the ability for users (me specifically) to tailor the feeds to be easier to read and browse

Do you want to implement this feature yourself?

  • Yes, I will implement this by myself and send a pull request
@noridev
Copy link
Collaborator

noridev commented Oct 1, 2024

Can you elaborate on the "option to show replied-to notes without grey filter"?
Does it mean that the notes get greyer as they go down, when they are long or have items that affect the federation?

noridev added a commit that referenced this issue Oct 1, 2024
- 리액션한 노트는 옵션 활성화 유무와 상관없이 항상 표시됩니다.
@noridev noridev mentioned this issue Oct 1, 2024
@breadguyyy
Copy link
Author

Can you elaborate on the "option to show replied-to notes without grey filter"? Does it mean that the notes get greyer as they go down, when they are long or have items that affect the federation?

sorry I'm not explaining it right I mean how the notes that are replied to are greyed out, makes it hard to read without opening the whole thread. example:

Screenshot_20241001-053943

@noridev
Copy link
Collaborator

noridev commented Oct 1, 2024

I understand :)
To prevent timeline terrorism and readability, notes longer than 500 characters or longer than 9 lines are automatically hidden.

This is Misskey's standard, and I think it's better to keep it if possible, but there may be users who want to tolerate this and set it to show all the contents.

CherryPick is designed to give users a choice in this conflict of opinions.

Therefore, I plan to add a feature to unconditionally expand the contents regardless of the conditions, but the default will be set to off to prevent the above problem.

@noridev
Copy link
Collaborator

noridev commented Oct 1, 2024

This is the current development progress.

  • option to show replied-to notes without grey filter
  • option to collapse replied-to notes in feed
  • option to always open the full conversation when opening a post
  • option to always uncollapse CWs
  • option to always uncollapse long posts

@breadguyyy
Copy link
Author

nice! To clarify though, I mean that those posts are greyed out even when expanded. might be hard to tell in the screenshots but you can see that the title bar and post text of the first note are darker than in the one below it

@breadguyyy
Copy link
Author

breadguyyy commented Oct 1, 2024

using the new patch and it's a game changer for me thank you so much!!
I have a couple of notes:
-by "collapse notes replied to" I meant the reply target notes
-reply target notes seem to have smaller text
-usernames seem to be horizontally cramped on the new patch
-files are still collapsed in them as well, even with all the collapse settings disabled
Screenshot_20241001-121316

@noridev
Copy link
Collaborator

noridev commented Oct 1, 2024

reply target notes seem to have smaller text
-> To make it easier to distinguish between content, the font size of the reply target note is set to be displayed smaller.
This somewhat solves the problem of it being difficult to distinguish between replies and original text in long notes.
It's the same reason why the original text looks greyer than the reply.

usernames seem to be horizontally cramped on the new patch
-> This is a change made in Misskey v2024.9.0.
You can disable this feature in 'Settings - Other - Experimental features - Enable condensed line'.

@breadguyyy
Copy link
Author

ahhh I see thank you!!

@noridev
Copy link
Collaborator

noridev commented Oct 1, 2024

files are still collapsed in them as well, even with all the collapse settings disabled
-> Could you elaborate a bit more on this issue?
It seems to be working fine in my environment.

image image

@breadguyyy
Copy link
Author

Screenshot_20241001-140544
Screenshot_20241001-140522
maybe it's only an issue on mobile?
pixel 8a, Vivaldi pwa

@noridev
Copy link
Collaborator

noridev commented Oct 1, 2024

The problem is not reproduced in my mobile environment... :(
My Android 14, Chrome PWA environment did not reproduce the same issue.

telegram-cloud-photo-size-5-6332098026142811475-y
telegram-cloud-photo-size-5-6332098026142811476-y

@breadguyyy
Copy link
Author

so odd I turned it on, cleared cache, turned it back off, cleared cache, and idk I can't get it to show automatically. we're on beta 4 btw

@breadguyyy
Copy link
Author

just noticed another thing, notes still have partial transparency when revealed by the "show conversation" button

@breadguyyy
Copy link
Author

breadguyyy commented Oct 3, 2024

maybe it's only an issue on mobile? pixel 8a, Vivaldi pwa

finally tested on desktop, getting the same issue. i believe it's only reply targets with text and media that remain collapsed

noridev added a commit that referenced this issue Oct 8, 2024
  - `답글을 자동으로 더 보기`를 활성화하면 `더 보기` 버튼을 누르지 않아도 노트 내 답글을 전부 표시합니다.
  - `대화를 자동으로 더 보기`를 활성화하면 `대화 보기` 버튼을 누르지 않아도 노트 내 대화를 전부 표시합니다.
@noridev
Copy link
Collaborator

noridev commented Oct 8, 2024

The development of the requested features has been completed.
In addition, the issue where some reply target notes were transparent has been fixed.

Since the implementation of the features has been completed, this issue will be closed for now. If any errors occur in the future, please create a new issue. :)

If a problem occurs with a specific feature, please test whether the problem occurs at beta.kokonect.link to control variables and identify the cause.

  • option to show replied-to notes without grey filter
  • option to collapse replied-to notes in feed
  • option to always open the full conversation when opening a post
  • option to always uncollapse CWs
  • option to always uncollapse long posts

@noridev noridev closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants