Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(backend): replace bcrypt with argon2 #511

Merged
merged 2 commits into from
Oct 5, 2024

Conversation

KiTTYsh
Copy link

@KiTTYsh KiTTYsh commented Oct 5, 2024

What

  • Change password hashing algorithm from bcrypt to argon2.
  • Retain login compatibility with bcrypt algorithm, and re-hash passwords that still use bcrypt during sign-on.

Why

Additional info (optional)

Cherrypicked 7111c6c9 and e17dcd78 from Sharkey.

Testing performed:

  • Passwords working after migrating to CherryPick from Sharkey ✅
  • Passwords working for new accounts created before and after this commit ✅
  • pnpm test performed with 100% success ✅
  • Docker container built and run successfully ✅
  • Running in production for a week on kitty.social without any issues

Checklist

  • [✅] Read the contribution guide
  • [✅] Test working in a local environment
  • [🟧] (If needed) Update CHANGELOG_CHERRYPICK.md
  • [❌] (If possible) Add tests

@noridev noridev self-requested a review October 5, 2024 12:28
@noridev noridev merged commit 81920f1 into kokonect-link:develop Oct 5, 2024
4 of 5 checks passed
@noridev
Copy link
Collaborator

noridev commented Oct 5, 2024

🙏🙏🙏

@Linux-Is-Best
Copy link

Awesome!

This will help and encourage people to move to CherryPick. 🥳

noridev added a commit that referenced this pull request Oct 5, 2024
)

  - 72 바이트를 초과하는 비밀번호를 사용할 수 있습니다.
  - 이로써 `Sharkey`, `FireFish`, `IceShrimp` 등의 클라이언트에서 `CherryPick`으로 이전할 때 암호 호환성이 보장됩니다.
@noridev noridev mentioned this pull request Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants