fix: Update data_type retrieval to not modify underlying dict
#558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates `data_type` retrieval in `_deserialize_dataobject` to use `get` instead of `pop`, so that the underlying dictionary is unmodified. This fixes a bug where `data_type` was removed from all dicts during deserialization.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #558 +/- ##
==========================================
+ Coverage 94.79% 94.81% +0.01%
==========================================
Files 83 83
Lines 5168 5168
Branches 736 736
==========================================
+ Hits 4899 4900 +1
Misses 194 194
+ Partials 75 74 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this PR introduce and why?
Updates
data_typeretrieval in_deserialize_dataobjectto usegetinstead ofpop, so that the underlying dictionary is unmodified. This fixes a bug wheredata_typewas removed from all dicts during deserialization.Please check if the PR fulfills these requirements