fix(parse): resolve jsan references before transformation #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Can you add a unit test for this? Thanks |
|
added |
|
Thanks! |
This was referenced Nov 29, 2018
zalmoxisus
added a commit
that referenced
this pull request
Dec 1, 2018
* Revert "Remove trailing spaces" This reverts commit 0db9d7b. * Revert "refactor(test): remove debugger breakpoint" This reverts commit 9ab247e. * Revert "fix(test): assert on deserialized object with references which should be resolved" This reverts commit 2f76353. * Revert "refactor(immutable-test): remove const with var for old verions of js engines" This reverts commit 0e9cc5d. * Revert "Update package-lock.json" This reverts commit bba3737. * Revert "fix(mocha): revert mocha package version for old versions of node" This reverts commit 0ab7902. * Revert "test(immutable): add integration tests for remotedev-serialize" * Revert "fix(parse): resolve jsan references before transformation" * Add unit test for reviver * Test also if reviver function has any effect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.