fix!: Combine exporter and endpoint #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A release (without a major update has been published)... https://github.com/kolonialno/troncos/releases/tag/v4.4.0 Adding release-please to prevent this happening again... |
|
Yeah I know. That's whats happens if we just merge stuff to main and let it live there without a release for a longer period. |
|
Yes was not a good move. Release please will fix this. |
|
@eirsyl Still waiting for a review on this PR ... |
|
Yeah, I can review it. It is better to ask directly if you are waiting on me. Just assigning PRs does not work anymore.
This is just half the list... |
eirsyl
reviewed
Feb 5, 2024
gbbirkisson
force-pushed
the
gbbirkisson/exporter-change
branch
from
ef7038b to
a121a70
Compare
eirsyl
reviewed
Feb 5, 2024
| exporter_type = ExporterType.HTTP | ||
| assert exporter_type, "You have to specify 'exporter_type'" | ||
|
|
||
| self.endpoint = f"{scheme}://{host}:{port}{path}" |
eirsyl
approved these changes
Feb 5, 2024
gbbirkisson
force-pushed
the
gbbirkisson/exporter-change
branch
from
a121a70 to
8079205
Compare
This was referenced Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this #282 introduces a breaking change to the api, I wanted to use the opportunity to merge endpoint and exporter into one param in
configure_tracer.